Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casting follower crashes on invalid capdata #8579

Closed
samsiegart opened this issue Nov 29, 2023 · 1 comment · Fixed by #8562
Closed

Casting follower crashes on invalid capdata #8579

samsiegart opened this issue Nov 29, 2023 · 1 comment · Fixed by #8562
Assignees
Labels
bug Something isn't working

Comments

@samsiegart
Copy link
Contributor

Describe the bug

We noticed the dapps weren't getting wallet updates in Agoric/ui-kit#57. More details in the issue comments, but it turns out when an offer to close a vault fails (e.g. due to insufficient IST in one's purse), the vstorage update in published.wallet.agoric1[useraddress] contains an error object that cannot be parsed as valid capdata by @endo/marshal. This was causing the follower in casting to crash silently and stop yielding updates for offer statuses. This would also cause the next offer status update to fail, because when you load the dapp, it would hit this error, and the follower would crash.

To Reproduce

Steps to reproduce the behavior:

  1. Open a vault on app.inter.trade
  2. Try to close the vault with insufficient IST in your purse
  3. Notice that you never see the offer status update in the toast

Expected behavior

The status update is able to be unserialized as valid capdata and the casting follower doesn't break

@samsiegart samsiegart added the bug Something isn't working label Nov 29, 2023
@ivanlei
Copy link
Contributor

ivanlei commented Nov 29, 2023

Fixed by @samsiegart with #8562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants