Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport x/crisis non halt #8581

Closed
ivanlei opened this issue Nov 30, 2023 · 0 comments · Fixed by #8582
Closed

Backport x/crisis non halt #8581

ivanlei opened this issue Nov 30, 2023 · 0 comments · Fixed by #8582
Assignees
@mhofman
Labels
agoric-cosmos enhancement New feature or request

Comments

@ivanlei
Copy link
Contributor

ivanlei commented Nov 30, 2023

What is the Problem Being Solved?

Backport the fix for GHSA-qfc5-6r3j-jj22 which prevents unnecessary chain halt.

This obviates the need to resolve GHSA-w5w5-2882-47pc

Security Considerations

This is a risk reduction

Scaling Considerations

None. This is not scaling related.

Test Plan

Issuing crisis check should not halt on chain with artificial crisis.
Code review should confirm removal of halting behavior.

Upgrade Considerations

This should be safe for upgrade with normal testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhofman mhofman

Labels
agoric-cosmos enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cosmos): un-wire x/crisis Agoric/agoric-sdk
2 participants
@mhofman @ivanlei