Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liveslots relaxDurabilityMode admits Promises when it should reject them #9599

Closed
warner opened this issue Jun 27, 2024 · 0 comments · Fixed by #9539
Closed

liveslots relaxDurabilityMode admits Promises when it should reject them #9599

warner opened this issue Jun 27, 2024 · 0 comments · Fixed by #9539
Assignees
Labels
bug Something isn't working liveslots requires vat-upgrade to deploy changes SwingSet package: SwingSet

Comments

@warner
Copy link
Member

warner commented Jun 27, 2024

We have "fake vat" testing environments which configure their copy of
liveslots with a setting named relaxDurabilityRules = true. This
changes the rules for durable objects, which normally refuse to accept
non-durable state. When the rules are relaxed, they accept ephemeral
and merely-virtual objects as well.

Promises were never supposed to be accepted, even when the rules are
relaxed. But liveslots has a bug, and accepts Promises in the relaxed
mode.

Lacking this enforcement, some other packages had mistakenly stored
Promises in durable objects, and gotten away with it. When we fix liveslots to not accept Promises in durable state, we will also need to update those packages to follow the rules.

@warner warner added bug Something isn't working SwingSet package: SwingSet liveslots requires vat-upgrade to deploy changes labels Jun 27, 2024
@warner warner self-assigned this Jun 27, 2024
@mergify mergify bot closed this as completed in #9539 Jul 10, 2024
@mergify mergify bot closed this as completed in 0006934 Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working liveslots requires vat-upgrade to deploy changes SwingSet package: SwingSet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant