Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async-flow test of host vow rejection #9705

Closed
mhofman opened this issue Jul 13, 2024 · 0 comments · Fixed by #9704
Closed

Add async-flow test of host vow rejection #9705

mhofman opened this issue Jul 13, 2024 · 0 comments · Fixed by #9704
Assignees
Labels
asyncFlow related to membrane-based replay and upgrade of async functions enhancement New feature or request

Comments

@mhofman
Copy link
Member

mhofman commented Jul 13, 2024

What is the Problem Being Solved?

#9703 was not discovered until we had a test case of an orchestrated contract failure.

We should have caught this in async-flow testing instead.

Description of the Design

Add a test where a host API returns a rejected vow (either immediate or through shortening). The guest does not need to let the error propagate and can handle the rejected guest promise.

@mhofman mhofman added enhancement New feature or request asyncFlow related to membrane-based replay and upgrade of async functions labels Jul 13, 2024
@mhofman mhofman self-assigned this Jul 13, 2024
@mhofman mhofman linked a pull request Jul 13, 2024 that will close this issue
@mergify mergify bot closed this as completed in #9704 Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asyncFlow related to membrane-based replay and upgrade of async functions enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant