chore(cosmic-proto): Add eslint coverage #10483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
86cd3c2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://41f1e1ee.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2024-11-cosmic-proto.agoric-sdk.pages.dev |
turadg
requested changes
Nov 14, 2024
packages/cosmic-proto/package.json
Outdated
| "lint": "tsc", | ||
| "lint": "run-s --continue-on-error lint:*", | ||
| "lint:types": "tsc", | ||
| "lint:eslint": "eslint $(sed 's/#.*//; /[^[:space:]]/ s/^/--ignore-pattern /' .eslintignore) .", |
There was a problem hiding this comment.
This is unnecessarily hacky. The higher level config is at project root, so if that's causing problems we should fix it there.
But I'm not sure any of this is worth the effort. What do you want to eslint in this package? It's mostly codegen.
There was a problem hiding this comment.
What do you want to eslint in this package? It's mostly codegen.
I encountered an issue here while working on another PR, but I don't remember where.
This is unnecessarily hacky. The higher level config is at project root, so if that's causing problems we should fix it there.
OK, fair point. Done.
turadg
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some higher-level configuration is overriding the local .eslintignore, so this PR works around that by copying its lines into--ignore-patternCLI options.Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
n/a
Upgrade Considerations
n/a