Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telemetry): event name typo #10551

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

mujahidkay
Copy link
Member

Description

Fixes typo for kernel upgrade event

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

Shouldn't affect operations

Upgrade Considerations

Chain software but doesn't affect consensus as it's an optional (off by default) plugin

@mujahidkay mujahidkay requested a review from a team as a code owner November 22, 2024 06:40
@mujahidkay mujahidkay self-assigned this Nov 22, 2024
@mujahidkay mujahidkay requested a review from mhofman November 22, 2024 06:42
Copy link

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e19321
Status: ✅  Deploy successful!
Preview URL: https://471270e6.agoric-sdk.pages.dev
Branch Preview URL: https://mk-fix-swingset-kernel-event.agoric-sdk.pages.dev

View logs

Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this in review

@mujahidkay mujahidkay added the automerge:rebase Automatically rebase updates, then merge label Nov 22, 2024
@mergify mergify bot merged commit 0105e1a into master Nov 22, 2024
91 checks passed
@mergify mergify bot deleted the mk/fix-swingset-kernel-event branch November 22, 2024 12:19
mujahidkay added a commit that referenced this pull request Dec 9, 2024
### Description

Cherry-picks the following commits from master:
- #10551
(9e19321)
- #10635
(ad4e83e)
- #10615
(e596a01 )
- #10634
(a1856f3)

Since we plan to verify this rc on devnet rather than emerynet, there is
no apparent need for a new upgrade name. Not aware of any deployments on
devnet before so can reuse the previous upgrade name. However, skipping
emerynet is dependent on comms with the validators so I have added a new
upgrade name `agoric-ugprade-18-emerynet-rc3` just in case. Only added
to bypass the need for a new rc if for some reason emerynet validation
is needed anyways - best case scenario is that it remains unused.

commits added using git cherry-pick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants