Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dATOM brand name to DEVNET config #10634

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

mujahidkay
Copy link
Member

Description

Updates brand names for DEVNET config in price feed updates

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

None

Upgrade Considerations

needed to verify u18 rc3 on DEVNET without yoinking the dATOM core eval deployed there.

@mujahidkay mujahidkay requested a review from a team as a code owner December 6, 2024 03:59
@mujahidkay mujahidkay self-assigned this Dec 6, 2024
@mujahidkay mujahidkay requested a review from toliaqat December 6, 2024 04:11
@mujahidkay mujahidkay added the automerge:rebase Automatically rebase updates, then merge label Dec 6, 2024
@mergify mergify bot merged commit 3653dc7 into master Dec 6, 2024
91 checks passed
@mergify mergify bot deleted the mk/add-datom-brand-to-devnet branch December 6, 2024 05:17
mujahidkay added a commit that referenced this pull request Dec 9, 2024
### Description

Cherry-picks the following commits from master:
- #10551
(9e19321)
- #10635
(ad4e83e)
- #10615
(e596a01 )
- #10634
(a1856f3)

Since we plan to verify this rc on devnet rather than emerynet, there is
no apparent need for a new upgrade name. Not aware of any deployments on
devnet before so can reuse the previous upgrade name. However, skipping
emerynet is dependent on comms with the validators so I have added a new
upgrade name `agoric-ugprade-18-emerynet-rc3` just in case. Only added
to bypass the need for a new rc if for some reason emerynet validation
is needed anyways - best case scenario is that it remains unused.

commits added using git cherry-pick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants