fix(telemetry): timer-poll run.id #10672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
0a4a720
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://255d2d12.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mhofman-fix-timer-poll.agoric-sdk.pages.dev |
mujahidkay
approved these changes
Dec 11, 2024
mujahidkay
pushed a commit
that referenced
this pull request
Dec 11, 2024
refs: #10357 ## Description I did a bad copy paste in #10357, which causes the `run.id` of `timer-poll` triggers to all end up with the value `timer-poll-undefined`. Use the blockHeight instead. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations None ### Testing Considerations Not tested ### Upgrade Considerations Would be nice to pick in u18-rc4
mujahidkay
added a commit
that referenced
this pull request
Dec 13, 2024
### Description Cherry-picks the following commits from master: - #10672 (3b478fb) - #10668 (a74161c) - #10680 (c883c39, 1581127) No new upgrade name has been added. Done partially via git cherry-pick and via the following rebase-todo: ``` # PR #10680 Branch Record-instances-that-will-be-replaced-so-we-can-manage-them-10680- label base-Record-instances-that-will-be-replaced-so-we-can-manage-them-10680- pick c883c39 feat: record instances that will be replaced so we can manage them pick 1581127 refactor: provideRetiredInstances label pr-10680--Record-instances-that-will-be-replaced-so-we-can-manage-them-10680- reset base-Record-instances-that-will-be-replaced-so-we-can-manage-them-10680- merge -C d35659b pr-10680--Record-instances-that-will-be-replaced-so-we-can-manage-them-10680- # Record instances that will be replaced so we can manage them (#10680) ```
mujahidkay
added a commit
that referenced
this pull request
Dec 13, 2024
## Description Created as per instructions in MAINTAINERS.md ## Changes - agoric@0.22.0-u18.4 - @agoric/benchmark@0.1.1-u18.4 - @agoric/boot@0.2.0-u18.4 - @agoric/builders@0.2.0-u18.4 - @agoric/cosmic-swingset@0.42.0-u18.4 - @agoric/create-dapp@0.1.1-u18.4 - fast-usdc@0.1.1-u18.4 - @agoric/inter-protocol@0.17.0-u18.4 - @agoric/solo@0.11.0-u18.4 - @agoric/swingset-runner@0.22.3-u18.4 - @agoric/telemetry@0.6.3-u18.3 ## Packages that have NEWS.md updates ```diff --- a/packages/boot/CHANGELOG.md +++ b/packages/boot/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.2.0-u18.4](https://github.com/Agoric/agoric-sdk/compare/@agoric/boot@0.2.0-u18.3...@agoric/boot@0.2.0-u18.4) (2024-12-13) + + +### Features + +* record instances that will be replaced so we can manage them ([3b1a35d](3b1a35d)) + + + ## [0.2.0-u18.3](https://github.com/Agoric/agoric-sdk/compare/@agoric/boot@0.2.0-u18.2...@agoric/boot@0.2.0-u18.3) (2024-12-09) **Note:** Version bump only for package @agoric/boot --- a/packages/builders/CHANGELOG.md +++ b/packages/builders/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.2.0-u18.4](https://github.com/Agoric/agoric-sdk/compare/@agoric/builders@0.2.0-u18.3...@agoric/builders@0.2.0-u18.4) (2024-12-13) + + +### Features + +* record instances that will be replaced so we can manage them ([3b1a35d](3b1a35d)) + + + ## [0.2.0-u18.3](https://github.com/Agoric/agoric-sdk/compare/@agoric/builders@0.2.0-u18.2...@agoric/builders@0.2.0-u18.3) (2024-12-09) **Note:** Version bump only for package @agoric/builders --- a/packages/inter-protocol/CHANGELOG.md +++ b/packages/inter-protocol/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.17.0-u18.4](https://github.com/Agoric/agoric-sdk/compare/@agoric/inter-protocol@0.17.0-u18.3...@agoric/inter-protocol@0.17.0-u18.4) (2024-12-13) + + +### Features + +* record instances that will be replaced so we can manage them ([3b1a35d](3b1a35d)) + + + ## [0.17.0-u18.3](https://github.com/Agoric/agoric-sdk/compare/@agoric/inter-protocol@0.17.0-u18.2...@agoric/inter-protocol@0.17.0-u18.3) (2024-12-09) **Note:** Version bump only for package @agoric/inter-protocol --- a/packages/telemetry/CHANGELOG.md +++ b/packages/telemetry/CHANGELOG.md @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +### [0.6.3-u18.3](https://github.com/Agoric/agoric-sdk/compare/@agoric/telemetry@0.6.3-u18.2...@agoric/telemetry@0.6.3-u18.3) (2024-12-13) + + +### Bug Fixes + +* **telemetry:** timer-poll run.id ([#10672](#10672)) ([4185e77](4185e77)), closes [#10357](#10357) [#10357](#10357) + + + ### [0.6.3-u18.2](https://github.com/Agoric/agoric-sdk/compare/@agoric/telemetry@0.6.3-u18.1...@agoric/telemetry@0.6.3-u18.2) (2024-12-09) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #10357
Description
I did a bad copy paste in #10357, which causes the
run.idoftimer-polltriggers to all end up with the valuetimer-poll-undefined. Use the blockHeight instead.Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Not tested
Upgrade Considerations
Would be nice to pick in u18-rc4