feat: robustify allManagersDo #9833
Conversation
Chris-Hibbert
added
code-style
Deploying agoric-sdk with
|
| Latest commit: |
193b443
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ee3c6ec8.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9706-allmgrsdo.agoric-sdk.pages.dev |
| @@ -82,6 +82,18 @@ const trace = makeTracer('VD', true); | |||
|
|
|||
| const shortfallInvitationKey = 'shortfallInvitation'; | |||
|
|
|||
| // exported for testing | |||
| export const makeAllManagersDo = (collateralManagers, vaultManagers) => { | |||
There was a problem hiding this comment.
swallowing errors like this seems unusual enough to merit a comment
There was a problem hiding this comment.
done. I also added a red flashing light 🚨
There was a problem hiding this comment.
Should this be yellow? we seem to be recovering from it.
But I guess it does indicate a bug - a "this should never happen" situation, not just some client mis-behaving or something. So ok, yes, red.
There was a problem hiding this comment.
Should this be yellow? we seem to be recovering from it.
We recover from the loop, but we don't do anything about the individual vaultManager that died while setting up liquidations or locking prices. I think that's mostly okay because it will get another opportunity the next time around, but if one manager keeps failing, it should get attention.
I have no objection, but I can't think of an appropriate place to write more. What did you have in mind? Is this just the comment on the function that you requested? |
yes. |
closes: #9706 ## Description make `allManagersDo` robust to errors thrown by one vaultManager ### Security Considerations Prevent issues in one vaultManager from blocking progress in others. This would affect liquidation and locking oracle prices for upcoming liquidation auctions. ### Scaling Considerations Doesn't add work. ### Documentation Considerations Not user visible ### Testing Considerations added a tiny unit test. ### Upgrade Considerations added robustness shouldn't impact upgrade.
closes: #9706 ## Description make `allManagersDo` robust to errors thrown by one vaultManager ### Security Considerations Prevent issues in one vaultManager from blocking progress in others. This would affect liquidation and locking oracle prices for upcoming liquidation auctions. ### Scaling Considerations Doesn't add work. ### Documentation Considerations Not user visible ### Testing Considerations added a tiny unit test. ### Upgrade Considerations added robustness shouldn't impact upgrade.
closes: #9706
Description
make
allManagersDorobust to errors thrown by one vaultManagerSecurity Considerations
Prevent issues in one vaultManager from blocking progress in others. This would affect liquidation and locking oracle prices for upcoming liquidation auctions.
Scaling Considerations
Doesn't add work.
Documentation Considerations
Not user visible
Testing Considerations
added a tiny unit test.
Upgrade Considerations
added robustness shouldn't impact upgrade.