feat: add null upgrade of vaultFactoryGovernor to upgrade-vaults.js #9953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
Governance
produced when switching into Yarn 4 branch
turadg
force-pushed
the
5200-upgradeVMGovernor
branch
from
cdb8a0c to
347c4c7
Compare
Deploying agoric-sdk with
|
| Latest commit: |
6010064
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7d0e0028.agoric-sdk.pages.dev |
| Branch Preview URL: | https://5200-upgradevmgovernor.agoric-sdk.pages.dev |
turadg
approved these changes
Aug 23, 2024
| START_FREQUENCY.toString(), | ||
| ); | ||
|
|
||
| console.log('Ensure debt ceiling changes'); |
There was a problem hiding this comment.
This tests that a vaultManager param can change. It doesn't test pausing offers. I don't have a theory for how this pausing offers could fail when this works.
Chris-Hibbert
added
the
automerge:rebase
Chris-Hibbert
force-pushed
the
5200-upgradeVMGovernor
branch
from
3abceff to
6010064
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #5200
Description
Do a null upgrade of the vaultFactory governor contract in the coreEval that upgrades the vaultFactory contract.
Security Considerations
If the governor is correctly connected to the contract (tests in process), and can govern parameters and enable offer filters, then everything is connected as it was, and there are no new security issues.
Scaling Considerations
None.
Documentation Considerations
No user-visible changes.
Testing Considerations
Test governance of the vaultFactory thoroughly on a testnet.
Upgrade Considerations
It appears that contract governor may be upgradeable..