Batch fertilizer concentrations #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemical_area_density pattern @marieALaporte
should be working now.
added fertilizer_chemicals-area_density as subclasses to molecular_entity-area_density
connect CAD to chemicals under respective area densities
Update chemical_area_density.yaml
cmungall
approved these changes
Nov 1, 2021
|
could you update the pattern file, so the categories can be inferred and not asserted, as a fertilizer can belong to multiple categories? |
updated equivalent classes updated make/patterns recipe to include robot merge
Created chemical_area_density_eq: added eq statements to existing inorganic fertiliser classes via pattern Updated chemical_area_density: added eq statements
|
@marieALaporte Done! can be merged. see latest 2 commit for patterns added. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using dosdp-tools, created pattern file (CAD) to create chemical-specific
chemical area densitylinking list of chemicals (associated with CHEBI's fertilizer [role]) and area densitiesAdditional details and closes issue #122
@marieALaporte
@celineaubert