Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player background image goes black when stream stops #352

Closed
bchah opened this issue May 3, 2023 · 4 comments
Closed

Player background image goes black when stream stops #352

bchah opened this issue May 3, 2023 · 4 comments
Assignees

Comments

@bchah
Copy link
Contributor

bchah commented May 3, 2023

Hi @SangwonOh - OvenPlayer goes to a black background (or whatever you set background-color as in the player container) when the stream stops, even if it is initialized with a background image. Would it be possible to go back to the background image when the stream stops instead?

Video example: https://user-images.githubusercontent.com/33604674/236021782-895a6abb-02a4-4ccd-bac4-47bb17e8fe9d.mp4

I started on a workaround for this but it feels like a feature improvement that would make OvenPlayer better for everybody. Hopefully you agree 😀

@SangwonOh SangwonOh self-assigned this May 4, 2023
@SangwonOh
Copy link
Member

@bchah Hi! I fixed the Video element to correctly redisplay the poster image when the playback fails. Please check v0.10.28! Thanks.

@bchah
Copy link
Contributor Author

bchah commented May 19, 2023

@SangwonOh Thank you! This is a good improvement 👍🏻 If you have time, can you also implement the same behaviour when calling player.load(source) ? Right now if the source is not live when this method is called, it exhibits the same behaviour of the disappearing background.

bchah referenced this issue May 26, 2023
For display poster image on playback error when call load()
@bchah
Copy link
Contributor Author

bchah commented May 26, 2023

Fixed in 0bdfcf7 !!

🥇🥇🥇🥇🥇🥇

@bchah bchah closed this as completed May 26, 2023
@SangwonOh
Copy link
Member

@bchah Hi!. Thanks for testing!💯 And also released to v0.10.29! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants