-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OvenPlayer leaking DOM nodes #363
Comments
OvenPlayer debug log:
|
I had some time over the weekend to dig into what is causing the DOM node leaks and have found 3 causes. I've created a PR with fixes for these and everything now looks good after running the garbage collector the number of used nodes returns back to the starting level and I'm not seeing any gradual slow down anymore. [https://github.com//pull/365] |
@rebound-software Thank you very much for your contribution! The pull request has been merged. |
I'm using OvenPlayer (latest 0.10.30) in an angular 12 based web application to view several live feeds via WebRTC from OME. The nature of my use case involves repeated viewing and recording short (1-2mins) of live video feed from a camera. The browser used is Chrome.
OvenPlayer is instantiated in a component to show the live feed which is then destroyed when the next view is displayed. The component is then re-instantiated for the next recording, and repeat ...
What I'm seeing is a leak of ~3k DOM nodes from OvenPlayer after calling stop() then remove() in the component OnDestroy() hook. My application needs to run continuously for many hours. The DOM node leak is causing the browser to gradually slow down to the point of becoming unusable after about 30 mins (DOM node use checked after manually running garbage collector).
Component html:
My component code is:
DOM nodes after viewing component above, then browsing away, then viewing again about 10 times:
The text was updated successfully, but these errors were encountered: