Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector Promotion uses RequestOperationType Create #740

Closed
aindriu-aiven opened this issue Mar 2, 2023 · 1 comment
Closed

Connector Promotion uses RequestOperationType Create #740

aindriu-aiven opened this issue Mar 2, 2023 · 1 comment
Assignees
@aindriu-aiven
Labels
Backend Backend tasks

Comments

@aindriu-aiven
Copy link
Contributor

What happened?

When promoting a connector it creates the Request type as a 'Create' operation but it should be a 'Promote' operation.

What did you expect to happen?

It should use the promote operation. So that when promote specific logic is needed it is easy to separate out the two types of requests.

What else do we need to know?

This appears in Version 2.0.0
There is a number of places that the logic will need to be updated to accommodate the change to Promote so this is not a simple change.
@aindriu-aiven aindriu-aiven added the Backend Backend tasks label Mar 2, 2023
@aindriu-aiven
Copy link
Contributor Author

This was resolved in PR #1253

@aindriu-aiven aindriu-aiven self-assigned this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aindriu-aiven aindriu-aiven

Labels
Backend Backend tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aindriu-aiven