Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guideline for commit messages #94

Closed
programmiri opened this issue Oct 17, 2022 · 6 comments · Fixed by #106
Closed

Add guideline for commit messages #94

programmiri opened this issue Oct 17, 2022 · 6 comments · Fixed by #106
Assignees
Labels
documentation Improvements or additions to documentation triaged Acknowledged

Comments

@programmiri
Copy link
Contributor

programmiri commented Oct 17, 2022

What?

We want to add a guideline for writing commit messages. This will make our commit history more consistent.

It will be part of / added to a CONTRIBUTING file later.

@programmiri programmiri self-assigned this Oct 17, 2022
@programmiri programmiri changed the title Add guidline for commit messages Add guideline for commit messages Oct 17, 2022
@programmiri
Copy link
Contributor Author

Suggestions

@jlprat
Copy link
Contributor

jlprat commented Oct 18, 2022

I like the guidelines under https://www.conventionalcommits.org/en/v1.0.0/

@SmuliS
Copy link
Contributor

SmuliS commented Oct 18, 2022

I also think that Conventional Commits is a good default and we should not try to reinvent the wheel. I would describe the commit type with text label instead of emojis. Emojis look nice in GitHub, but they are not as explicit with some text based tools.

Do you think we should repeat the (copy) the main points to the document or only refer to that external resource?

@programmiri
Copy link
Contributor Author

Sounds good to me! 👯

I would add the main points in our doc in form of a condensed bullet list which is fast to skim, while refer to the external resources for more details. That way, the contributors don't have to leave the source in most cases (if they don't want to read up more details), which I feel is a nice usability. At least for people that tend to be a bit impatient (or eager, which is a nicer way to put it 😅 ) like me.

I can make a PR for that.

❓ should I already make that a CONTRIBUTING file or should it be a temp commits.md until we have CONTRIBUTING and move it over?

@SmuliS
Copy link
Contributor

SmuliS commented Oct 18, 2022

Lets add the guide directly to CONTRIBUTING. I think it does not need to be complete from first commit as we have #99 that describes the desired state.

@programmiri
Copy link
Contributor Author

Thanks! Then I'll make a PR for that 🏃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation triaged Acknowledged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants