-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guideline for commit messages #94
Comments
Suggestions
|
I like the guidelines under https://www.conventionalcommits.org/en/v1.0.0/ |
I also think that Conventional Commits is a good default and we should not try to reinvent the wheel. I would describe the commit type with text label instead of emojis. Emojis look nice in GitHub, but they are not as explicit with some text based tools. Do you think we should repeat the (copy) the main points to the document or only refer to that external resource? |
Sounds good to me! 👯 I would add the main points in our doc in form of a condensed bullet list which is fast to skim, while refer to the external resources for more details. That way, the contributors don't have to leave the source in most cases (if they don't want to read up more details), which I feel is a nice usability. At least for people that tend to be a bit impatient (or eager, which is a nicer way to put it 😅 ) like me. I can make a PR for that. ❓ should I already make that a |
Lets add the guide directly to |
Thanks! Then I'll make a PR for that 🏃 |
What?
We want to add a guideline for writing commit messages. This will make our commit history more consistent.
It will be part of / added to a CONTRIBUTING file later.
The text was updated successfully, but these errors were encountered: