Consider removing parentheses from clip name?

[apiszcz]

I set clean_file=no, however parens and spaces still appear

Eliminate spaces and parenthesis.

FROM
    filename = string.format(
            '%s (%s-%s)',
            filename,
            human_readable_time(main_menu.timings['start']),
            human_readable_time(main_menu.timings['end'])

TO
    filename = string.format(
            '%s_%s_%s',
            filename,
            human_readable_time(main_menu.timings['start']),
            human_readable_time(main_menu.timings['end'])

[apiszcz]

BTW fantastic effort, appreciate the utility.

[apiszcz]

I am finding certain filename (perhaps with strange characters (not sure which characters might be the problem) are causing the write to clip to fail:

        notify(string.format("Error: couldn't create the clip.\nDoes %s exist?", location), "error", 5)

[tatsumoto-ren]

Eliminate spaces and parenthesis.
%s_%s_%s

Looks fine.

[tatsumoto-ren]

certain filename are causing the write to clip to fail

any examples?

[apiszcz]

Working on understanding it. Some files work others don't, plan to report when I get time on this.

[apiszcz]

It may not be a filename issue, the error statement could be due to a general processing problem/error, what is the best way to find out the debug / errors from the follow (not a 'lua' expert)

I think i need to see the output of
local process_result = function(_, ret, _)

    if clip_type == 'video' then
        args = encoder.mkargs_video(clip_filename)
        location = config.video_folder_path
    else
        args = encoder.mkargs_audio(clip_filename)
        location = config.audio_folder_path
    end

    **local process_result = function(_, ret, _)**
        if ret.status ~= 0 or string.match(ret.stdout, "could not open") then
            notify(string.format("Error: couldn't create the clip.\nDoes %s exist?", location), "error", 5)
        else
            notify(string.format("Clip saved to %s.", location), "info", 2)
        end
    end

[tatsumoto-ren]

The parameters the function takes are success, result, error. Try outputting them with print().

[apiszcz]

using notify(res.stdout) works, tried print not sure where output goes (did not see in console)

Error couldn't create the clip

Some files work and some don't so the output path is ok, speculating it is the encoder command failing. need to see that command line output

tried notify(args) after if clip_type == 'video'
however only Please wait... displays

progress on windows you have to use mpv.com NOT mpv.exe to see print/console output

created a hello-world.lua and it works fine printing to console, however videoclip.lua does not print
when I use notify lua error mp.defaults :568 is not a string

maybe this is related to the issue?
print(ret.error)
[videoclip] nil

the problem appears to be related to the files, videoclip is fine. However if there is a way to display the error or stack trace when the clip is not successful that would be useful. I'd like to be able to run the command line that videoclip generates but have not figure out how to display that at this time.

[tatsumoto-ren]

tried print not sure where output goes (did not see in console)

If you launch mpv from the terminal, it goes to the terminal. Otherwise you should see it if you press ~ while mpv is open.

you have to use mpv.com NOT mpv.exe to see print/console output

I didn't know about this. On GNU/Linux the executable is just mpv.

lua error mp.defaults :568 is not a string

try converting parameters with tostring()

[apiszcz]

mpv.com on windows displays to the console.