From 0299aa8807347581eb136ab6070063376f50f87f Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde Date: Wed, 23 Mar 2022 19:44:37 +0530 Subject: [PATCH] k8s_exec: Update deprecation warning (#419) k8s_exec: Update deprecation warning SUMMARY return_code is deprecated in favor of rc, update the deprecation warning to tell user about the reason behind this. Fixes: #417 Signed-off-by: Abhijeet Kasurde akasurde@redhat.com ISSUE TYPE Bugfix Pull Request COMPONENT NAME changelogs/fragments/417_deprecation.yml plugins/modules/k8s_exec.py Reviewed-by: Mike Graves --- changelogs/fragments/417_deprecation.yml | 3 +++ plugins/modules/k8s_exec.py | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/417_deprecation.yml diff --git a/changelogs/fragments/417_deprecation.yml b/changelogs/fragments/417_deprecation.yml new file mode 100644 index 0000000000..7d87985efe --- /dev/null +++ b/changelogs/fragments/417_deprecation.yml @@ -0,0 +1,3 @@ +--- +minor_changes: +- k8s_exec - update deprecation warning for `return_code` (https://github.com/ansible-collections/kubernetes.core/issues/417). diff --git a/plugins/modules/k8s_exec.py b/plugins/modules/k8s_exec.py index f13ec7df77..f2c5666075 100644 --- a/plugins/modules/k8s_exec.py +++ b/plugins/modules/k8s_exec.py @@ -212,7 +212,8 @@ def execute_module(module, k8s_ansible_mixin): rc = int(err["details"]["causes"][0]["message"]) module.deprecate( - "The 'return_code' return key is deprecated. Please use 'rc' instead.", + "The 'return_code' return key is being renamed to 'rc'. " + "Both keys are being returned for now to allow users to migrate their automation.", version="4.0.0", collection_name="kubernetes.core", )