Logging #33
Open
Logging #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having some issues building it on Windows, but I'll get that part figured out. In the meantime, from glancing at the code it looks like printlevel and log level are coupled together, so by default we would be dumping a bunch of uniquely named textfiles into the users directory everytime the console comes up. Instead, I think we should have it be toggleable and be off by default. |
|
The unique files are for multiple PSIOPT instances and aren't directly related to the level. I wanted to avoid the case where multiple instances are all simultaneously dumping to the same file, which would make it basically unreadable. I do agree there should be a toggle though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapped all PSIOPT printing to
spdlog. Output is now duplicated to terminal and log file. Current implementation has file level set totrace, and console level tied to the oldPSIOPT::PrintLevel.I don't love the filename uniqueness code, but I think we have to do something like that for when there are multiple PSIOPT instances, like in Jet.
Probably closes #25