From 7f57397817a2855ab9264c890005d6d461da89e2 Mon Sep 17 00:00:00 2001 From: Dale Sande Date: Fri, 13 Dec 2019 22:09:02 -0800 Subject: [PATCH] fix: update issue templates --- .github/.DS_Store | Bin 0 -> 6148 bytes .github/CODE_OF_CONDUCT.md | 2 +- .github/CONTRIBUTING.md | 2 +- .github/ISSUE_TEMPLATE.md | 34 --------- .github/ISSUE_TEMPLATE/bug_report.md | 38 ++++++++++ .github/ISSUE_TEMPLATE/config.yml | 1 + .github/ISSUE_TEMPLATE/feature_request.md | 20 +++++ .github/ISSUE_TEMPLATE/general-support.md | 30 ++++++++ template/.DS_Store | Bin 0 -> 6148 bytes template/.github/.DS_Store | Bin 0 -> 6148 bytes template/.github/CODE_OF_CONDUCT.md | 2 +- template/.github/CONTRIBUTING.md | 71 ++++++++++++++++-- template/.github/ISSUE_TEMPLATE.md | 34 --------- template/.github/ISSUE_TEMPLATE/bug_report.md | 38 ++++++++++ template/.github/ISSUE_TEMPLATE/config.yml | 1 + .../.github/ISSUE_TEMPLATE/feature_request.md | 20 +++++ .../.github/ISSUE_TEMPLATE/general-support.md | 30 ++++++++ 17 files changed, 247 insertions(+), 76 deletions(-) create mode 100644 .github/.DS_Store delete mode 100644 .github/ISSUE_TEMPLATE.md create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/config.yml create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md create mode 100644 .github/ISSUE_TEMPLATE/general-support.md create mode 100644 template/.DS_Store create mode 100644 template/.github/.DS_Store delete mode 100644 template/.github/ISSUE_TEMPLATE.md create mode 100644 template/.github/ISSUE_TEMPLATE/bug_report.md create mode 100644 template/.github/ISSUE_TEMPLATE/config.yml create mode 100644 template/.github/ISSUE_TEMPLATE/feature_request.md create mode 100644 template/.github/ISSUE_TEMPLATE/general-support.md diff --git a/.github/.DS_Store b/.github/.DS_Store new file mode 100644 index 0000000000000000000000000000000000000000..7a21cfbce12365aae3a76329e3c735979e6d5c92 GIT binary patch literal 6148 zcmeHKJxc>Y5PhR50)nKp+`r&ISVK|>3c_ivgi@5)c}%?HA95o~PaO_+JR zbMtn&SKMR(*!tu75?BFP(jBq)FgJhhKC_d`7?I91ws^!n<1OxH)yEUgJ;yZ${vIa$ z8(jHWpTqm^^=piAO-%F0=C!;n>Amldh6`vyw^7R6WwbLbT_Vp o!VvA4810xFZ^su=ly%M5eBKMk#Go@DbfW$YxGpj&@Yf1_0S#Ui6aWAK literal 0 HcmV?d00001 diff --git a/.github/CODE_OF_CONDUCT.md b/.github/CODE_OF_CONDUCT.md index 8aedac0f..2177c3da 100644 --- a/.github/CODE_OF_CONDUCT.md +++ b/.github/CODE_OF_CONDUCT.md @@ -1,4 +1,4 @@ -# Orion Design System Code of Conduct +# Code of Conduct ## Our Pledge diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 8ab6cf16..7fa2eee4 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -1,4 +1,4 @@ -# Orion Design System Contributing Guidelines +# Contributing Guidelines Please take a moment to review this document in order to make the contribution process easy and effective for everyone involved. diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md deleted file mode 100644 index 196a122b..00000000 --- a/.github/ISSUE_TEMPLATE.md +++ /dev/null @@ -1,34 +0,0 @@ -# Issue report - -Your issue may already be reported! Please search on the issue tracker before creating one. - -## Expected Behavior - - - -## Current Behavior - - - -## Possible Solution - - - -## Steps to Reproduce (for bugs) - - -1. -2. -3. -4. - -## Context - - - -## Your Environment - -* Version used: -* Browser Name and version: -* Operating System and version (desktop or mobile): -* Link to your project: diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..4e311b89 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,38 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: 'Type: Bug' +assignees: blackfalcon + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Desktop (please complete the following information):** + - OS: [e.g. iOS] + - Browser [e.g. chrome, safari] + - Version [e.g. 22] + +**Smartphone (please complete the following information):** + - Device: [e.g. iPhone6] + - OS: [e.g. iOS8.1] + - Browser [e.g. stock browser, safari] + - Version [e.g. 22] + +**Additional context** +Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 00000000..3ba13e0c --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1 @@ +blank_issues_enabled: false diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 00000000..774e23b9 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,20 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: 'Type: Feature' +assignees: blackfalcon + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. diff --git a/.github/ISSUE_TEMPLATE/general-support.md b/.github/ISSUE_TEMPLATE/general-support.md new file mode 100644 index 00000000..99d4c5da --- /dev/null +++ b/.github/ISSUE_TEMPLATE/general-support.md @@ -0,0 +1,30 @@ +--- +name: General support +about: Suggestions that are not related to bugs or new features +title: '' +labels: 'Type: Question' +assignees: blackfalcon + +--- + +# General Support Request + + + +## Support request + + +## Possible Solution + + + +## Context + + + +## Your Environment + +* Version used: +* Browser Name and version: +* Operating System and version (desktop or mobile): +* Link to your project: diff --git a/template/.DS_Store b/template/.DS_Store new file mode 100644 index 0000000000000000000000000000000000000000..9c7e095a39565e9fec75f52b03c6c0fb8e8f112e GIT binary patch literal 6148 zcmeHKOG-mQ5Uh>?1KDKha!w$4gCQg*$OR+_QIH5?vVNBc8SOA#O9dYt7Ha~YC*`zW?r1Oqv9I!oZ-uJI>qw4Dk=icHTJG|iI zJAc2+Td&iUl>$;g3P=GdAO(J@fcIY7Y@Vnn1*Cu!I4j`ahemhog+pR|Iv8REAWoSM z<2q&uV)F#C7Y>Qc&@8FMq*{#_mUQM@)%C(5G3l@xKCGT>HKABMo%gpWhxJ57DIf(d z6}ZXm!u$W4{=@u#NzzUVNP&N)fK6AM)snANy>;|*-fJ8Ek?u90bT_Vp!VvA4810xF fZ^w60ly%M5Jnw}=V$hinI#E9Zu8T|x{IvpK{InHg literal 0 HcmV?d00001 diff --git a/template/.github/.DS_Store b/template/.github/.DS_Store new file mode 100644 index 0000000000000000000000000000000000000000..7a21cfbce12365aae3a76329e3c735979e6d5c92 GIT binary patch literal 6148 zcmeHKJxc>Y5PhR50)nKp+`r&ISVK|>3c_ivgi@5)c}%?HA95o~PaO_+JR zbMtn&SKMR(*!tu75?BFP(jBq)FgJhhKC_d`7?I91ws^!n<1OxH)yEUgJ;yZ${vIa$ z8(jHWpTqm^^=piAO-%F0=C!;n>Amldh6`vyw^7R6WwbLbT_Vp o!VvA4810xFZ^su=ly%M5eBKMk#Go@DbfW$YxGpj&@Yf1_0S#Ui6aWAK literal 0 HcmV?d00001 diff --git a/template/.github/CODE_OF_CONDUCT.md b/template/.github/CODE_OF_CONDUCT.md index 4e0007f3..ddcb324a 100644 --- a/template/.github/CODE_OF_CONDUCT.md +++ b/template/.github/CODE_OF_CONDUCT.md @@ -1,4 +1,4 @@ -# Orion Design Tokens Code of Conduct +# Code of Conduct ## Our Pledge diff --git a/template/.github/CONTRIBUTING.md b/template/.github/CONTRIBUTING.md index 0c2be6fb..d980b3c7 100644 --- a/template/.github/CONTRIBUTING.md +++ b/template/.github/CONTRIBUTING.md @@ -1,4 +1,4 @@ -# Orion Design Tokens Contributing Guidelines +# Contributing Guidelines Please take a moment to review this document in order to make the contribution process easy and effective for everyone involved. @@ -22,14 +22,61 @@ Poor bug reports will be reassigned back to the creator for revision prior to an ## Submitting pull requests -No one other than repository managers have direct access to the repository. For all pull requests you must first fork the project to your own Github account. +No one other than repository managers have direct access to the repository. For all pull requests you must first fork the project to your own Github account. All new work that is to be considered for merging with the `MASTER` branch must start from a new feature branch of work. This feature branch should be in response to either a bug or a new business requirement. -#### Feature branch naming +### Feature branch naming The name of the feature branch should be descriptive as to the nature of the work and please include any references to the story or bug work item ID. +### Conventional Commits + +This project utilizes [Conventional Commits](https://www.conventionalcommits.org/) to auto-generate release verions, based on the [Angular Commit Message Guidelines](https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#-commit-message-guidelines). + + +``` +[optional scope]: +``` + +All commit messages must be prefixed with a specific type so that the semver release configuration can analyze the commit and apply the correct version release. Please see the following types with their respective meanings. + +#### MAJOR + +For a MAJOR release, you MUST follow this template. The use of `perf:` and `BREAKING CHANGE:` are needed in order to push a major release. + +``` +perf(pencil): remove graphiteWidth option + +BREAKING CHANGE: The graphiteWidth option has been removed. +The default graphite width of 10mm is always used for performance reasons. +``` + +#### MINOR +``` +feat(pencil): add 'graphiteWidth' option +``` + +#### PATCH +``` +fix(pencil): stop graphite breaking when too much pressure applied +``` + +#### Other commit types + +| type | description | +|---|---| +| build | Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) | +| ci | Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs) | +| docs | Documentation only changes | +| feat | A new feature (this correlates with `MINOR` in semantic versioning) | +| fix | A bug fix (this correlates with `PATCH` in semantic versioning) | +| perf | A code change that improves performance (correlating with `MAJOR` in semantic versioning) | +| BREAKING CHANGE | A code change that is not backwards compatable (correlating with `MAJOR` in semantic versioning) | +| refactor | A code change that neither fixes a bug nor adds a feature | +| style | Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc) | +| test | Adding missing tests or correcting existing tests | + #### Git commit messages Once you have completed your feature update, please commit all changes to the branch. All commit messages should use an **imperative mood**. @@ -49,11 +96,25 @@ For example: * If applied, this commit will `refactor component X for accessibility` * If applied, this commit will `add feature Y to component X` -#### Push branch and submit pull request +Example messages when using Conventional Commits: + +``` +$ build: update to Gulp 4.x + +$ docs: address issue #14, typo in install instructions + +$ perf: restructure API to comply with new feature spec + +$ feat: add ability to consume large data as an array versus string + +$ fix: address issue #57 in regards to color output +``` + +### Push branch and submit pull request One you have committed new work to your feature branch, be sure to push your updates to the Github repository. Depending on your IDE or CLI configuration this may be a manual or automatic step. -To submit a new pull request, please go to [https://github.com/AlaskaAirlines](https://github.com/AlaskaAirlines) to find your project and submit the Pull Request. +To submit a new pull request, please go to [https://github.com/AlaskaAirlines](https://github.com/AlaskaAirlines) to find your project and submit the Pull Request. On the pull request page, the new pull request should be `[your-new-branch] into [master]` diff --git a/template/.github/ISSUE_TEMPLATE.md b/template/.github/ISSUE_TEMPLATE.md deleted file mode 100644 index 196a122b..00000000 --- a/template/.github/ISSUE_TEMPLATE.md +++ /dev/null @@ -1,34 +0,0 @@ -# Issue report - -Your issue may already be reported! Please search on the issue tracker before creating one. - -## Expected Behavior - - - -## Current Behavior - - - -## Possible Solution - - - -## Steps to Reproduce (for bugs) - - -1. -2. -3. -4. - -## Context - - - -## Your Environment - -* Version used: -* Browser Name and version: -* Operating System and version (desktop or mobile): -* Link to your project: diff --git a/template/.github/ISSUE_TEMPLATE/bug_report.md b/template/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..4e311b89 --- /dev/null +++ b/template/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,38 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: 'Type: Bug' +assignees: blackfalcon + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Desktop (please complete the following information):** + - OS: [e.g. iOS] + - Browser [e.g. chrome, safari] + - Version [e.g. 22] + +**Smartphone (please complete the following information):** + - Device: [e.g. iPhone6] + - OS: [e.g. iOS8.1] + - Browser [e.g. stock browser, safari] + - Version [e.g. 22] + +**Additional context** +Add any other context about the problem here. diff --git a/template/.github/ISSUE_TEMPLATE/config.yml b/template/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 00000000..3ba13e0c --- /dev/null +++ b/template/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1 @@ +blank_issues_enabled: false diff --git a/template/.github/ISSUE_TEMPLATE/feature_request.md b/template/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 00000000..774e23b9 --- /dev/null +++ b/template/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,20 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: 'Type: Feature' +assignees: blackfalcon + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. diff --git a/template/.github/ISSUE_TEMPLATE/general-support.md b/template/.github/ISSUE_TEMPLATE/general-support.md new file mode 100644 index 00000000..99d4c5da --- /dev/null +++ b/template/.github/ISSUE_TEMPLATE/general-support.md @@ -0,0 +1,30 @@ +--- +name: General support +about: Suggestions that are not related to bugs or new features +title: '' +labels: 'Type: Question' +assignees: blackfalcon + +--- + +# General Support Request + + + +## Support request + + +## Possible Solution + + + +## Context + + + +## Your Environment + +* Version used: +* Browser Name and version: +* Operating System and version (desktop or mobile): +* Link to your project: