Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCSS: AS Circular ligatures active in global styling #80

Closed
tombauer85 opened this issue May 14, 2021 · 8 comments · Fixed by #82
Closed

WCSS: AS Circular ligatures active in global styling #80

tombauer85 opened this issue May 14, 2021 · 8 comments · Fixed by #82
Assignees
Labels
Status: Work In Progress Issue or Pull Request work is in Progress Type: Question Further information is requested

Comments

@tombauer85
Copy link

Per AS brand guidelines (pg. 13), ligatures should not be active for the AS Circular font on AS.com.

Steps to reproduce the behavior:

  1. Go to AS.com
  2. View the CTA "Find flight deals now"
  3. Observe that the ligature is active and most commonly occurs with the letter combination f + l.

Expected behavior:
No ligatures active for digital experiences on AS.com and MOW.

Screenshots

As_MOW_ligature
AS_desktop_ligature

Desktop:

  • Browser: All browsers

Smartphone:

  • MOW: All devices
@tombauer85 tombauer85 added the Type: Bug Bug or Bug fixes label May 14, 2021
@blackfalcon
Copy link
Member

@tombauer85 thanks for submitting this issue, but I am afraid I have no real resource to correct this. This issue has to do with the font library and the Auro team has no control over that.

When using WCSS, the code for the web font is here https://github.com/AlaskaAirlines/WebCoreStyleSheets/blob/master/src/_fonts.scss. That being said, what individual teams are doing is not in our control.

That being said, if you look at the page you are referencing, using the inspector you can add letter-spacing: 0.1px and that ligature is dropped. We could add that to WCSS as a default, but that is not our decision, that needs to come from design. Not to mention, it feels a little hackie.

@blackfalcon blackfalcon added Type: Question Further information is requested and removed Type: Bug Bug or Bug fixes labels May 14, 2021
@blackfalcon blackfalcon added the Status: Work In Progress Issue or Pull Request work is in Progress label May 14, 2021
@blackfalcon
Copy link
Member

With letter-spacing: 0.1px set at the page level. All type is affected by this.

Screen Shot 2021-05-14 at 1 53 04 PM

@blackfalcon blackfalcon changed the title AS Circular ligatures active in global styling WCSS: AS Circular ligatures active in global styling May 14, 2021
@tombauer85
Copy link
Author

@blackfalcon interesting, so we can't apply this code to the global styling?

font-variant-ligatures: no-common-ligatures;

When I add this to the CSS under "body, html" it seems to render all text without ligatures.

Screen Shot 2021-05-14 at 1 55 16 PM

@blackfalcon
Copy link
Member

Yeah, font-variant-ligatures would do the work and is not as hacky. Yeah, we do that 100!

@tombauer85
Copy link
Author

Great, thanks! @blackfalcon

@blackfalcon blackfalcon linked a pull request May 14, 2021 that will close this issue
6 tasks
AuroDesignSystem pushed a commit that referenced this issue May 20, 2021
# [3.4.0](v3.3.2...v3.4.0) (2021-05-20)

### Features

* add support for font-variant-ligatures to essentials file [#80](#80) ([916c3a7](916c3a7))
@tombauer85
Copy link
Author

Hi @blackfalcon, just wanted to check in on this. It doesn't look like the ligature issue was ever fixed on the homepage. Was this added to the global styling? Could you please let me know if there is any action on the content production end to finally fix this issue?
Screen Shot 2021-08-17 at 11 07 25 AM

@blackfalcon
Copy link
Member

Hey @tombauer85 this update was released with v3.4.0. Can you confirm with the team as to what version of WCSS they are using?

This was added to the essentials file, so please verify if that resource is being used.

@tombauer85
Copy link
Author

Talked to Steven and Marnel about this, Content Enablement is working on getting the latest WCSS imported globally either this sprint or next. Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Work In Progress Issue or Pull Request work is in Progress Type: Question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants