Dropdown: render proper border when dropdown gets clicked #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Reviewer's Guide by SourceryThis PR introduces a fix to the dropdown border rendering issue and enhances the dropdown component with a new "fluid" attribute. It also updates the documentation to reflect these changes. Class diagram for dropdown component changesclassDiagram
class AuroDropdown {
+Boolean fluid
+display: inline-block
+handleClick()
+handleFocusLoss()
}
class AuroFloatingUI {
+handleClick()
+handleFocusLoss()
+handleEvent(event)
}
AuroDropdown --|> AuroFloatingUI
note for AuroDropdown "New fluid attribute added
Default display set to inline-block"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
sun-mota
force-pushed
the
sunMota/dropdown-focus-border
branch
from
2ff889f to
9b3b7ae
Compare
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @sun-mota - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR description mentions a new 'fluid' attribute but there are no related code changes in the diff. Please either update the PR description to match the actual changes or add the missing implementation for the 'fluid' attribute.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
sun-mota
force-pushed
the
sunMota/dropdown-focus-border
branch
2 times, most recently
from
f8017c5 to
31b7a76
Compare
…` stays in body even with clicking #129
sun-mota
force-pushed
the
sunMota/dropdown-focus-border
branch
2 times, most recently
from
6d2c44c to
de5727c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Before Submitting this pull request:
Developmentsectionnote: all pull requests require at least one linked ticket
Ready For Review, all ticket's linked underDevelopmentmust have their status changed toReady For Reviewas wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Update dropdown styles to render a proper border when the dropdown is clicked or active, and ensure the dropdown retains focus when clicked.
Bug Fixes:
Enhancements: