Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-radio: incorrect a11y experience #22

Closed
blackfalcon opened this issue Mar 22, 2021 · 2 comments · Fixed by #24
Closed

auro-radio: incorrect a11y experience #22

blackfalcon opened this issue Mar 22, 2021 · 2 comments · Fixed by #24
Assignees
Labels
Status: Review Needed Work is completed, user is requesting feedback Type: Bug Bug or Bug fixes

Comments

@blackfalcon
Copy link
Member

Describe the bug

Not sure if this pull request is the cause, but it's been discovered that when selecting a radio button option on a mobile device, there is a blue halo.

This is only appearing with a radio-group.

This is not the expected experience when working with an Auro element.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://auro.alaskaair.com/components/auro/radio
  2. Click on any option in a radio group
  3. See the error

Expected behavior

When tapping on a radio option, there should be no halo.

Screenshots

Screen Shot 2021-03-22 at 9 09 05 AM

Smartphone (please complete the following information):

  • OS: iOS
  • Browser: Safari
  • Latest version
@blackfalcon blackfalcon self-assigned this Mar 22, 2021
@blackfalcon
Copy link
Member Author

Issue is currently assigned to @blackfalclon to find root cause of this issue.

@geoffrich
Copy link
Contributor

It looks like whatever is compiling the Sass is combining the focus-visible declarations in WCSS, presumably because they share a ruleset:

.js-focus-visible :focus:not(.focus-visible), :focus:not(:focus-visible) { /* whatever */ }

They are separate in the _core.scss stylesheet to prevent browsers that do not support :focus-visible from throwing the whole rule out. With how it's currently minified, Safari will not remove focus styles as expected because it does not support focus-visible.

This may be the cause of the issue.

@blackfalcon blackfalcon linked a pull request Apr 12, 2021 that will close this issue
6 tasks
@blackfalcon blackfalcon added Status: Complete and Ready to Merge Status: Review Needed Work is completed, user is requesting feedback labels Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed Work is completed, user is requesting feedback Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants