From 4694f0627024ccd7bd852ca3ec274b477e037c09 Mon Sep 17 00:00:00 2001
From: Kanstantinas Piatrashka <piatrashkakanstantinass@gmail.com>
Date: Sun, 17 Dec 2023 19:31:16 +0200
Subject: [PATCH 1/2] fix #140

---
 better-frontend/src/pages/QuizPreview.tsx | 82 ++++++++++++-----------
 1 file changed, 42 insertions(+), 40 deletions(-)

diff --git a/better-frontend/src/pages/QuizPreview.tsx b/better-frontend/src/pages/QuizPreview.tsx
index 03c7c6d7..f9f942a9 100644
--- a/better-frontend/src/pages/QuizPreview.tsx
+++ b/better-frontend/src/pages/QuizPreview.tsx
@@ -20,7 +20,7 @@ import {
   DrawerContent,
   DrawerCloseButton,
 } from "@chakra-ui/react";
-import { ChatIcon } from "@chakra-ui/icons";
+import { ChatIcon, HamburgerIcon } from "@chakra-ui/icons";
 import {
   QuestionResponseDto,
   QuizManipulationRequestDto,
@@ -141,51 +141,51 @@ function QuizPreview() {
                 Start
               </Button>
             )}
+            {quiz.questions.length > 0 && (
+              <Button
+                onClick={async () => {
+                  if (generateButtonIsLoading) {
+                    return;
+                  }
+
+                  setGenerateButtonIsLoading(true);
+
+                  try {
+                    const newCollection =
+                      await createFromQuizFlashcardCollection(id);
+                    navigate(`/flashcard-collections/${newCollection.id}`);
+                  } catch (error) {
+                    toast({
+                      title: "Flashcard generation failed",
+                      description: `Whoops! ${(error as Error).message}`,
+                      status: "error",
+                      duration: 5000,
+                      isClosable: true,
+                    });
+                  }
+
+                  setGenerateButtonIsLoading(false);
+                }}
+                isDisabled={generateButtonIsLoading}
+              >
+                {generateButtonIsLoading
+                  ? "Generating..."
+                  : "Generate flashcards"}
+              </Button>
+            )}
             {(quiz.owner === undefined ||
               quiz.owner === authInfo?.username) && (
               <>
                 <Menu>
-                  <MenuButton as={Button} colorScheme="purple">
+                  <MenuButton
+                    colorScheme="purple"
+                    as={IconButton}
+                    aria-label="Options"
+                    icon={<HamburgerIcon />}
+                  >
                     Actions
                   </MenuButton>
                   <MenuList>
-                    {quiz.questions.length > 0 && (
-                      <MenuItem
-                        as={Button}
-                        onClick={async () => {
-                          if (generateButtonIsLoading) {
-                            return;
-                          }
-
-                          setGenerateButtonIsLoading(true);
-
-                          try {
-                            const newCollection =
-                              await createFromQuizFlashcardCollection(id);
-                            navigate(
-                              `/flashcard-collections/${newCollection.id}`
-                            );
-                          } catch (error) {
-                            toast({
-                              title: "Flashcard generation failed",
-                              description: `Whoops! ${
-                                (error as Error).message
-                              }`,
-                              status: "error",
-                              duration: 5000,
-                              isClosable: true,
-                            });
-                          }
-
-                          setGenerateButtonIsLoading(false);
-                        }}
-                        isDisabled={generateButtonIsLoading}
-                      >
-                        {generateButtonIsLoading
-                          ? "Generating..."
-                          : "Generate flashcards"}
-                      </MenuItem>
-                    )}
                     <MenuItem
                       as={Button}
                       textAlign="center"
@@ -219,7 +219,9 @@ function QuizPreview() {
       <Drawer isOpen={isOpen} placement="right" onClose={onClose} size="md">
         <DrawerOverlay />
         <DrawerContent>
-          <DrawerHeader fontSize="2xl" fontWeight="bold">Quiz discussion</DrawerHeader>
+          <DrawerHeader fontSize="2xl" fontWeight="bold">
+            Quiz discussion
+          </DrawerHeader>
           <DrawerCloseButton />
           <DrawerBody display="flex" alignItems="stretch">
             <QuizDiscussionBlock id={quiz.id} />

From f475859105c575eaf4e1ba5cfee8da78dc9d0156 Mon Sep 17 00:00:00 2001
From: Kanstantinas Piatrashka <piatrashkakanstantinass@gmail.com>
Date: Mon, 18 Dec 2023 13:11:59 +0200
Subject: [PATCH 2/2] implement suggested permission behavior

---
 better-frontend/src/pages/QuizPreview.tsx | 137 +++++++++++-----------
 1 file changed, 71 insertions(+), 66 deletions(-)

diff --git a/better-frontend/src/pages/QuizPreview.tsx b/better-frontend/src/pages/QuizPreview.tsx
index f9f942a9..fa6c5c82 100644
--- a/better-frontend/src/pages/QuizPreview.tsx
+++ b/better-frontend/src/pages/QuizPreview.tsx
@@ -20,7 +20,7 @@ import {
   DrawerContent,
   DrawerCloseButton,
 } from "@chakra-ui/react";
-import { ChatIcon, HamburgerIcon } from "@chakra-ui/icons";
+import { ChatIcon } from "@chakra-ui/icons";
 import {
   QuestionResponseDto,
   QuizManipulationRequestDto,
@@ -123,6 +123,18 @@ function QuizPreview() {
     return <SoloGame quiz={quiz} />;
   }
 
+  function withValidUser(f: () => void) {
+    if (quiz.owner !== undefined && quiz.owner !== authInfo?.username) {
+      toast({
+        title: "User is not authorized",
+        description: "You must be the owner of this quiz",
+        status: "error",
+        duration: 5000,
+        isClosable: true,
+      });
+    } else f();
+  }
+
   return (
     <>
       <QuizEditor
@@ -141,72 +153,65 @@ function QuizPreview() {
                 Start
               </Button>
             )}
-            {quiz.questions.length > 0 && (
-              <Button
-                onClick={async () => {
-                  if (generateButtonIsLoading) {
-                    return;
-                  }
-
-                  setGenerateButtonIsLoading(true);
-
-                  try {
-                    const newCollection =
-                      await createFromQuizFlashcardCollection(id);
-                    navigate(`/flashcard-collections/${newCollection.id}`);
-                  } catch (error) {
-                    toast({
-                      title: "Flashcard generation failed",
-                      description: `Whoops! ${(error as Error).message}`,
-                      status: "error",
-                      duration: 5000,
-                      isClosable: true,
-                    });
-                  }
-
-                  setGenerateButtonIsLoading(false);
-                }}
-                isDisabled={generateButtonIsLoading}
-              >
-                {generateButtonIsLoading
-                  ? "Generating..."
-                  : "Generate flashcards"}
-              </Button>
-            )}
-            {(quiz.owner === undefined ||
-              quiz.owner === authInfo?.username) && (
-              <>
-                <Menu>
-                  <MenuButton
-                    colorScheme="purple"
-                    as={IconButton}
-                    aria-label="Options"
-                    icon={<HamburgerIcon />}
+            <Menu>
+              <MenuButton as={Button} colorScheme="purple">
+                Actions
+              </MenuButton>
+              <MenuList>
+                {quiz.questions.length > 0 && (
+                  <MenuItem
+                    as={Button}
+                    onClick={async () => {
+                      if (generateButtonIsLoading) {
+                        return;
+                      }
+
+                      setGenerateButtonIsLoading(true);
+
+                      try {
+                        const newCollection =
+                          await createFromQuizFlashcardCollection(id);
+                        navigate(`/flashcard-collections/${newCollection.id}`);
+                      } catch (error) {
+                        toast({
+                          title: "Flashcard generation failed",
+                          description: `Whoops! ${(error as Error).message}`,
+                          status: "error",
+                          duration: 5000,
+                          isClosable: true,
+                        });
+                      }
+
+                      setGenerateButtonIsLoading(false);
+                    }}
+                    isDisabled={generateButtonIsLoading}
                   >
-                    Actions
-                  </MenuButton>
-                  <MenuList>
-                    <MenuItem
-                      as={Button}
-                      textAlign="center"
-                      onClick={() => setQuizForEdit(quiz)}
-                    >
-                      Edit
-                    </MenuItem>
-                    <MenuItem
-                      as={Button}
-                      colorScheme="red"
-                      onClick={async () => {
-                        await deleteQuiz(id);
-                        navigate("/");
-                      }}
-                    >
-                      Delete
-                    </MenuItem>
-                  </MenuList>
-                </Menu>
-              </>
-            )}
+                    {generateButtonIsLoading
+                      ? "Generating..."
+                      : "Generate flashcards"}
+                  </MenuItem>
+                )}
+                <MenuItem
+                  as={Button}
+                  textAlign="center"
+                  onClick={() => withValidUser(() => setQuizForEdit(quiz))}
+                >
+                  Edit
+                </MenuItem>
+                <MenuItem
+                  as={Button}
+                  colorScheme="red"
+                  onClick={() =>
+                    withValidUser(async () => {
+                      await deleteQuiz(id);
+                      navigate("/");
+                    })
+                  }
+                >
+                  Delete
+                </MenuItem>
+              </MenuList>
+            </Menu>
             <IconButton
               variant="outline"
               aria-label="Discussion"