Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a player's name to be edited at any time #78

Closed
AlecM33 opened this issue Jan 14, 2022 · 1 comment
Closed

Allow a player's name to be edited at any time #78

AlecM33 opened this issue Jan 14, 2022 · 1 comment
Labels
enhancement New feature or request User Experience

Comments

@AlecM33
Copy link
Owner

AlecM33 commented Jan 14, 2022 •
edited
Loading

Currently the name is entered on the join page, and if the join is successful, that permanently sets that clients name. We want clients to be able to edit their name in the lobby and during a game, and have that change broadcasted to the other clients.

Having an edit button built into this top banner on the game page might be a good implementation:

image
@AlecM33 AlecM33 added enhancement New feature or request wanted labels Jan 14, 2022
@AlecM33 AlecM33 changed the title Allow a player Allow a player's name to be edited at any time Jan 14, 2022
@AlecM33 AlecM33 removed the wanted label Jul 17, 2022
@AlecM33 AlecM33 removed the priority label Dec 14, 2022
@AlecM33 AlecM33 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2023
@AlecM33 AlecM33 reopened this Aug 7, 2023
@AlecM33 AlecM33 mentioned this issue Aug 14, 2023
Merged
@AlecM33
Copy link
Owner Author

AlecM33 commented Aug 14, 2023

implemented with #170

@AlecM33 AlecM33 closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request User Experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlecM33