fix: don't use async await on synchronous code

Rule-34 · Sep 4, 2020 · 91a0619 · 91a0619
1 parent e47d64a
commit 91a0619
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 14 deletions.
diff --git a/components/pages/posts/content/PostTags.vue b/components/pages/posts/content/PostTags.vue
@@ -47,14 +47,14 @@ export default {
   methods: {
     ...mapActions('booru', ['addedTagsManager', 'pidManager', 'fetchPosts']),
 
-    async fetchSpecificTag(tag) {
-      await this.pidManager({ operation: 'reset' })
+    fetchSpecificTag(tag) {
+      this.pidManager({ operation: 'reset' })
 
-      await this.addedTagsManager({
+      this.addedTagsManager({
         operation: 'reset',
       })
 
-      await this.addedTagsManager({
+      this.addedTagsManager({
         operation: 'add',
         value: tag,
       })

diff --git a/components/pages/posts/domain/Selector.vue b/components/pages/posts/domain/Selector.vue
@@ -91,18 +91,18 @@ export default {
       'fetchPosts',
     ]),
 
-    async changeDomain(domain) {
+    changeDomain(domain) {
       // Redirect to premium page
       if (domain === 'Add booru') {
         this.$router.push({ name: 'premium' })
         return
       }
 
-      await this.activeBooruManager({ operation: 'search', value: domain })
+      this.activeBooruManager({ operation: 'search', value: domain })
 
-      await this.pidManager({ operation: 'reset' })
+      this.pidManager({ operation: 'reset' })
 
-      await this.addedTagsManager({ operation: 'reset' })
+      this.addedTagsManager({ operation: 'reset' })
 
       this.fetchPosts()
 

diff --git a/components/pages/posts/navigation/search/SearchResults.vue b/components/pages/posts/navigation/search/SearchResults.vue
@@ -107,8 +107,8 @@ export default {
       }
     },
 
-    async fetchAddedTags() {
-      await this.pidManager({ operation: 'reset' })
+    fetchAddedTags() {
+      this.pidManager({ operation: 'reset' })
 
       await this.setSearchIsActive(false)
 

diff --git a/components/pages/posts/util/PostsStartupMixin.js b/components/pages/posts/util/PostsStartupMixin.js
@@ -12,9 +12,9 @@ export default {
   methods: {
     ...mapActions('booru', ['fetchPosts', 'pidManager']),
 
-    async setInitialPageIDAndFetch() {
+    setInitialPageIDAndFetch() {
       if (this.queries.pid === undefined)
-        await this.pidManager({ operation: 'reset' })
+        this.pidManager({ operation: 'reset' })
 
       if (!this.posts.data.length) this.fetchPosts()
     },

diff --git a/store/booru/index.js b/store/booru/index.js
@@ -265,9 +265,9 @@ export const actions = {
     )
 
     if (mode === 'concat') {
-      dispatch('postsManager', { operation: 'concat', value: response })
+      await dispatch('postsManager', { operation: 'concat', value: response })
     } else {
-      dispatch('postsManager', { operation: 'set', value: response })
+      await dispatch('postsManager', { operation: 'set', value: response })
     }
   },