Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wlr/taskbar not applying empty class #2564

Closed
alexander-zerpa opened this issue Oct 9, 2023 · 0 comments
Closed

wlr/taskbar not applying empty class #2564

alexander-zerpa opened this issue Oct 9, 2023 · 0 comments

Comments

@alexander-zerpa
Copy link

Waybar is only applying the empty class to the taskbar when the last window is closed, it also only applies it to the module that had that window icon.

This appears to only be a problem when all-outputs is set to false, so i believe that has something to do with how the taskbar is updated.

I don't know C++ nor have i ever work with GTK but looking at the code my guess is that in the function remove_button on line 880 of the taskbar.cpp file, when you check the tasks_ variable, it will only be empty when there are no more windows open, my instinct would be to use the box_ variable instead but it seems that gtk containers don't keep track of the amount of children they have, so maybe keeping track of that manually would be the path to follow.

When I'm free I will try to implement this and maybe do a pull request but since I'm not very confident on not making a hacky solution I'll leave this Issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants