Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory module tooltip is wrong and hardcoded #845

Closed
HarHarLinks opened this issue Aug 30, 2020 · 1 comment
Closed

Memory module tooltip is wrong and hardcoded #845

HarHarLinks opened this issue Aug 30, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@HarHarLinks
Copy link
Contributor

Waybar/src/modules/memory/common.cpp

Line 39 in 44119db

label_.set_tooltip_text(fmt::format("{:.{}f}Gb used", used_ram_gigabytes, 1));

The number is in Gigabytes (or actually more likely, Gibibytes GiB), however it is formatted as Gigabits (Gb).

Further this is hardcoded here and would be nice to be able to manipulate via the usual "tooltip-format" in the config.
@saidsay-so saidsay-so mentioned this issue Sep 2, 2020
Merged
@Alexays
Copy link
Owner

Alexays commented Sep 7, 2020

Fixed with #587

@Alexays Alexays closed this as completed Sep 7, 2020
@Alexays Alexays added the bug Something isn't working label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HarHarLinks @Alexays