Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursorline option to set visual selection color #100

Closed
TheLastEinherjar opened this issue Jan 1, 2024 · 5 comments · Fixed by #144
Closed

Cursorline option to set visual selection color #100

TheLastEinherjar opened this issue Jan 1, 2024 · 5 comments · Fixed by #144
Assignees
Labels
Enhancement New feature, request or suggestion Fixed on Dev This issue will be fixed in the next release

Comments

@TheLastEinherjar
Copy link
Contributor

I cant find an option to set the color to be used for visual selections.


Is the a way to set the color for visual selection, I can change the highlight group, but it would be nice to still be able to use the cursorline settings.

I think it would be better to have a option to set the bg color in cursorline which would then be used in the blend.
Instead of having a theme option.

If there is not something like that implemented and you are interested, I could make a pr for it?

@TheLastEinherjar
Copy link
Contributor Author

heres a commit for it on my alts fork: https://github.com/5-pebbles/nordic.nvim/commit/6eca1004874050740731233d5bb22ba4e0911086

@TheLastEinherjar
Copy link
Contributor Author

I did not mean to click that button....

@AlexvZyl AlexvZyl added the Enhancement New feature, request or suggestion label Jan 3, 2024
@AlexvZyl
Copy link
Owner

AlexvZyl commented Jan 3, 2024

Thanks for the commit link!

Would you be keen to make a PR?

Just a tip, if you make PR, please only include the changes you intend to make. I see you made a bunch of smaller changes in the linked commit :)

@5-pebbles
Copy link
Collaborator

Unfortunately I think those are need for it to work, I could hardcode the color, in the defaults which would substantially cut back on changes.

But if I don't, I need to move all option related changes, to a function (extend_colors) or I get a circular import.

@5-pebbles
Copy link
Collaborator

That pull request uses a hardcoded value, I will add use of the palette for default options in a different one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature, request or suggestion Fixed on Dev This issue will be fixed in the next release
Projects
None yet
3 participants