Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for change to AlfBreadcrumb #1388

Closed
tpage-alfresco opened this issue Oct 3, 2017 · 2 comments · Fixed by #1391
Closed

Add unit test for change to AlfBreadcrumb #1388

tpage-alfresco opened this issue Oct 3, 2017 · 2 comments · Fixed by #1391

Comments

@tpage-alfresco
Copy link
Member

In #1387 we added a call to encodeHTML to prevent a XSS issue in the breadcrumb trail. We should add a unit test to ensure this change is not regressed.

Currently the unit test framework is not working locally (at least I can't see how to run them - see also #1359 ) and so it's basically impossible for me to write unit tests.
This was referenced Oct 3, 2017
Merged
Merged
@tpage-alfresco
Copy link
Member Author

We also need to add a unit test for #1389.

@tunaaksoy
Copy link
Contributor

A unit test for #1390 has to be implemented as well.

@tunaaksoy tunaaksoy mentioned this issue Oct 6, 2017
Merged
@richard-smith-sky richard-smith-sky mentioned this issue Oct 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RM-5774: Bug fix and new unit tests Alfresco/Aikau
2 participants
@tunaaksoy @tpage-alfresco