Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT-24622] Add files via upload #4202

Merged
merged 17 commits into from
Nov 12, 2024
Merged

[MNT-24622] Add files via upload #4202

merged 17 commits into from
Nov 12, 2024

Conversation

lbiedrzycki
Copy link
Contributor

@swapnil-verma-gl
Copy link
Contributor

Hi. I think something went wrong during the commit. All the json translations files are now empty, except for en.json. Can you please verify?

Also, you do not need to create separate PRs for every commit. You can just commit and push to the same branch again, and the PR will automatically get updated with the new changes. ;)

@swapnil-verma-gl swapnil-verma-gl mentioned this pull request Oct 28, 2024
Closed
@lbiedrzycki
Copy link
Contributor Author

Hi, I checked the files and everything seems fine. Let me try to upload them once again.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lbiedrzycki
Copy link
Contributor Author

Hi Swapnil, I updated the pull request and the files are now in. Could you please confirm everything is alright now?

@swapnil-verma-gl
Copy link
Contributor

Hi Swapnil, I updated the pull request and the files are now in. Could you please confirm everything is alright now?

Yes, this looks much better now. Thanks!!

@AleksanderSklorz AleksanderSklorz changed the title Add files via upload [MNT-24622] Add files via upload Nov 12, 2024
@AleksanderSklorz AleksanderSklorz merged commit 1732542 into develop Nov 12, 2024
25 checks passed
@AleksanderSklorz AleksanderSklorz deleted the lbiedrzycki-ACA-translation-update branch November 12, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MateuszHY MateuszHY MateuszHY approved these changes

@swapnil-verma-gl swapnil-verma-gl swapnil-verma-gl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbiedrzycki @swapnil-verma-gl @MateuszHY @AleksanderSklorz