OPSEXP-2732 Add search enterprise metadata image Dockerfile #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmacius
commented
Jul 16, 2024
gionn
reviewed
Jul 17, 2024
test/postman/docker-compose/acs-test-docker-compose-collection.json
Outdated
Show resolved
Hide resolved
gionn
requested changes
Jul 17, 2024
|
|
||
| ADD search/enterprise/metadata/*-app.jar /opt/app.jar | ||
|
|
||
| CMD java $JAVA_OPTS -jar /opt/app.jar |
There was a problem hiding this comment.
it won't handle shutdown gracefully using this syntax because it will be wrapped in a sh -c
I think the only alternative is to have an external .sh script with the java command prepended with exec which is the built-in to replace the current process with a new process (which fix the shutdown issue)
you can test this using docker stop <container> and see it doesn't react until the kill timeout triggers in
There was a problem hiding this comment.
live-indexing-metadata-1 | 2024-07-17T13:14:12.041Z INFO 1 --- [nio-8080-exec-1] o.a.c.c.C.[Tomcat].[localhost].[/] : Initializing Spring DispatcherServlet 'dispatcherServlet'
live-indexing-metadata-1 | 2024-07-17T13:14:12.042Z INFO 1 --- [nio-8080-exec-1] o.s.web.servlet.DispatcherServlet : Initializing Servlet 'dispatcherServlet'
live-indexing-metadata-1 | 2024-07-17T13:14:12.042Z INFO 1 --- [nio-8080-exec-1] o.s.web.servlet.DispatcherServlet : Completed initialization in 0 ms
live-indexing-metadata-1 | 2024-07-17T13:14:57.696Z INFO 1 --- [ionShutdownHook] o.a.c.impl.engine.AbstractCamelContext : Apache Camel 4.1.0 (camel-1) is shutting down (timeout:45s)
live-indexing-metadata-1 | 2024-07-17T13:14:57.706Z INFO 1 --- [ionShutdownHook] o.a.c.impl.engine.AbstractCamelContext : Routes stopped (stopped:2)
live-indexing-metadata-1 | 2024-07-17T13:14:57.706Z INFO 1 --- [ionShutdownHook] o.a.c.impl.engine.AbstractCamelContext : Stopped metadata-consumer (sjms://org.alfresco.search.metadata.event)
live-indexing-metadata-1 | 2024-07-17T13:14:57.706Z INFO 1 --- [ionShutdownHook] o.a.c.impl.engine.AbstractCamelContext : Stopped retry-consumer (sjms://org.alfresco.search.metadata.retry.event)
live-indexing-metadata-1 | 2024-07-17T13:14:57.709Z INFO 1 --- [ionShutdownHook] o.a.c.impl.engine.AbstractCamelContext : Apache Camel 4.1.0 (camel-1) shutdown in 12ms (uptime:1m13s)
live-indexing-metadata-1 exited with code 143
docker-compose/docker-compose.yml
Outdated
| environment: | ||
| SPRING_ELASTICSEARCH_REST_URIS: http://elastic:9200 | ||
| SPRING_ACTIVEMQ_BROKERURL: nio://activemq:61616 | ||
| healthcheck: |
There was a problem hiding this comment.
can be moved into the dockerfile?
There was a problem hiding this comment.
Yes it can as a default behavior, it can still be overrode from docker compose.
There was a problem hiding this comment.
I was talking about the healthcheck xD
gionn
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: OPSEXP-2732