-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please set master to swift 3 :D #233
Comments
Hi @gperdomor, I suppose that you are talking about the Carthage configuration? The rationale behind the current setup can be found in the comments of #192 Moving to swift 3 would require to keep a swift 2.3 compatibility anyway as the swift version is not enforced "yet". It should be soon when Xcode will drop the support for it. Are you having a specific issue with this current setup? 😊 |
Hello @Liquidsoul, Yes, there is an issue here when you integrate this library using Carthage, since Carthage will use the project's In order to get this working with Carthage you'd have to fork it and change this value to Since Swift 2.3 is closer and closer to deprecation (Xcode 8.3 release could be less than a month away) I think it's safe to set Swift 3 as the default for this project. Thanks! |
Hi @piercifani, We made things so you should not need to fork the repository to use Carthage and Swift 3.0. As Xcode 8.3 is coming soon, maybe it is a good time to work on the Swift 2.3 to Swift 3.0 migration of the project. |
I forgot that you can also use dedicated releases for the library which have the |
oops... sorry, I didn't catch that! Thanks a lot! |
Note that I think in a near future we will indeed make Swift3 the default (and keep Swift2.3 releases for people having legacy projects), as Swift3 is indeed now the default for most people and 2.3 is dropped with Xcode 8.3 anyway. I just won't do a release just for that, but will wait until there's something to release to do that for the next version. |
Today is the day! 🥁🎉 |
I think we can finally close this 🍾🎉 |
Any reason why we master in still in swift 2.3?
The text was updated successfully, but these errors were encountered: