Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my own apps; pbxproj file keeps getting updated with OHTTPStubs .xctest lines when building #117

Closed
mikelupo opened this issue Sep 18, 2015 · 3 comments

Comments

@mikelupo
Copy link
Collaborator

Is this something in one of your test schemes that is causing this?

I have OHTTPStubs included as a sub project of my App project.
Note: We are not allowed to use cocoapods, nor are we allowed to check binary (lib) files into git. So when we use third party libraries, we have to include them in our source tree directly and build them at compile-time.

Example of my hierarchy:
MyProject.xcodeproj
--my project files
-- ...
----Test Folder
--------TestFrameworksFolder
------------ OHHTTPStubs.xcodeproj
---------------- OHHTTPStubs files/folders at this level
------------ KIF.xcodeproj
---------------- KIF files/folders at this level

In my Test target's BUILD SETTINGS in XCode:
Test Target dependencies are:
--OHHTTPStubs iOS Static Lib
--KIF
--myAppUnderTest

Linked in with:
--libOHHTTPStubs.a
--libKif.a
--ioKit.a

There are NO OHTTPStubs sources getting compiled directly in the test target (would not compile as it would be double declared)

What happens is that when I build my test target, I get various updates to my own pbxproj file which is causing us some headaches.

Example of a few diffs in my app's pbxproj file.

screen shot 2015-09-18 at 11 07 05 am

screen shot 2015-09-18 at 11 09 34 am

I do not have this issue with KIF, only OHHTTPStubs.
Thoughts?

@AliSoftware
Copy link
Owner

I think that's because I renamed targets at some point in the lifetime of OHHTTPStubs' project evolutions, (like I renamed "OHHTTPStubs iOS Tests" renamed to "OHHTTPStubs iOS Lib Tests" when I introduced the dynamic framework version to make the name of the target more clear) and probably Xcode didn't update it everywhere it should have in the OHHTTPStubs.xcodeproj/*pbxproj files and kept the old name at some places in the pbxproj, which it updates only at compile time in some circumstances… (that's just a guess but I've see that behavior of Xcode before).

Care to post a diff to list me all the modified files so I can see where Xcode missed them? Or provide a sample project to reproduce the issue so I can check the diffs myself?

Thx

@mikelupo
Copy link
Collaborator Author

It would be labor intensive I think to produce a project and work out reproducing instructions.
With that tidbit of history, I might be able to just do a find/replace in the project file and submit a PR.

I'll have a look
Thanks!

-----Original Message-----
From: AliSoftware notifications@github.com
To: AliSoftware/OHHTTPStubs OHHTTPStubs@noreply.github.com
Cc: mikelupo mikelupo@aol.com
Sent: Fri, Sep 18, 2015 11:48 am
Subject: Re: [OHHTTPStubs] my own apps; pbxproj file keeps getting updated with OHTTPStubs .xctest lines when building (#117)

I think that's because I renamed targets at some point in the lifetime of OHHTTPStubs' project evolutions, (like I renamed "OHHTTPStubs iOS Tests" renamed to "OHHTTPStubs iOS Lib Tests" when I introduced the dynamic framework version to make the name of the target more clear) and probably Xcode didn't update it everywhere it should have in the OHHTTPStubs.xcodeproj/*pbxproj files and kept the old name at some places in the pbxproj, which it updates only at compile time in some circumstances… (that's just a guess but I've see that behavior of Xcode before).

Care to post a diff to list me all the modified files so I can see where Xcode missed them? Or provide a sample project to reproduce the issue so I can check the diffs myself?

Thx


Reply to this email directly or view it on GitHub.

mikelupo pushed a commit to mikelupo/OHHTTPStubs that referenced this issue Sep 18, 2015
AliSoftware#117

my own apps's pbxproj file keeps getting updated
with OHTTPStubs iOS Tests .xctest lines when building.

Performed a find/replace in the following file:
OHHTTPStubs/OHHTTPStubs.xcodeproj/project.pbxproj

 for all instances of:
OHHTTPStubs iOS Tests
and changed it to:
OHHTTPStubs iOS Lib Tests
This was referenced Sep 18, 2015
AliSoftware added a commit that referenced this issue Sep 20, 2015
(Those old names were from before the rename when introducing the iOS framework)
@AliSoftware
Copy link
Owner

Versions 4.2.1 and 4.3.0 have been pushed with the project fixed, so you shouldn't have the issue anymore!

AliSoftware added a commit that referenced this issue Nov 3, 2015
(Those old names were from before the rename when introducing the iOS framework)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants