Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitespace and formatting #114

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

frank26080115
Copy link

do not merge yet!!!

I ran the automated styling tool astyle https://astyle.sourceforge.net/ on just the Src and Inc directory, using the rules in https://github.com/frank26080115/AM32-MultiRotor-ESC-firmware/blob/15eed95cf8ba1130f3bd358faf9c846f75ff0ae3/_astylerc

The build output binary does exactly match the binaries before I made the change. So it is guaranteed to not have changed any functionality at all

Anybody interested in continuing should have a look at the changes, and approve of the styling, and provide feedback

The next steps after I get some approvals:

  • apply same styling to the MCU directory, but excluding the STM32 library
  • manually make adjustments to whitespace that the automated tool did not cover

Every change will be built and the binary output will be compared with the original, just to make sure no actual functionality has changed at all.

After everything is done, all developers need to do a pull and merge into their own local repos. But, since none of the functionality has changed, the version number can remain the same.

@frank26080115
Copy link
Author

nobody complained about the changes on here or discord, and the binary output still matches what everything started with

it's ok to merge unless you want changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant