add skip button to hero page #5189
Conversation
There was a problem hiding this comment.
I’m not entirely sure if the original issue has been resolved. When a user uploads a project directory, they’re already redirected immediately to /app. @tobitege, could you confirm if this was the intended behavior?
In any case, we’ll need confirmation from Paul, the designer. "Skip" feels out of place here (there isn't quite anything to skip). Something like "Jump right in" might be more fitting.
| <button | ||
| className="absolute bottom-4 right-4 text-white px-4 py-2 rounded cursor-pointer border-1 border-neutral-600" | ||
| onClick={() => { | ||
| window.location.href = "/app"; |
There was a problem hiding this comment.
| window.location.href = "/app"; | |
| navigate("/app"); |
Further reading: https://remix.run/docs/hi/main/hooks/use-navigate
|
@amanape Personally, I don't plan to use this upload feature, but still use mapped local folder as my codebase doesn't use GitHub. |
|
@amanape was this discussed with Paul? |
|
@mamoodi Nope, Paul is occupied as of yet |
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
The linked issue was going stale and seemed quite helpful to have. Added a "skip" button to bypass the hero page. Followed general design theme for the button but feedback here would be appreciated!
Link of any specific issues this addresses
#4503