Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with expanding #1206

Closed
ashabi opened this issue Apr 9, 2017 · 6 comments
Closed

issues with expanding #1206

ashabi opened this issue Apr 9, 2017 · 6 comments

Comments

@ashabi
Copy link

ashabi commented Apr 9, 2017

Hi.
I am trying to use the expanding component but I have a few issues:

  1. the entire row can be clicked to open/close but it does not effect the className with this.selectRow. So therefore it does not add the class that I need nor does it remove it.
  2. I would like it to close all other rows when one is selected

any help is appreciated. thanks

@AllenFang
Copy link
Owner

HI @ashabi,

  1. you means selectRow.className is not added to the TR(row)?
  2. duplicated with Allow only a single row to expand at a time #1166

Thanks

@ashabi
Copy link
Author

ashabi commented Apr 9, 2017

Ok. I got #1 to work. But the this.state.expanding does not seem to be updating itself when you click on the row.
#2 is a duplicate. Any idea when this will be fixed?
thanks.

@AllenFang
Copy link
Owner

AllenFang commented Apr 10, 2017

could you please upgrade to newest version and try again for first issue, if the problem still remain, I think you can show me your code, thanks

for the second issue, Because there're a lots of issues need to fix so no schedule but I think I can support it in near future.

@AllenFang
Copy link
Owner

For the second issue, already release on v3.2.0, assign true to options.onlyOneExpanding to allow single expand row, default is false

@ashabi
Copy link
Author

ashabi commented Apr 18, 2017

hi. thanks, but is there is a state that defines this expanding? i noticed when you click on the tr it does not remove the selectRow.className

@AllenFang
Copy link
Owner

if you found any bug or possible issue, open another issue and provide some useful information for me, I'll check it 👍

BTW,

but is there is a state that defines this expanding?

I guess your answer is here but not very sure because what's your means actually

i noticed when you click on the tr it does not remove the selectRow.className

Actually, I dont know what's the configure for your case, please show me, and I just write a case with expanding and selection and assign selectRow.className and everything is work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants