Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize page button - Prop Type Error #1365

Closed
MethodenMann opened this issue May 30, 2017 · 4 comments
Closed

Customize page button - Prop Type Error #1365

MethodenMann opened this issue May 30, 2017 · 4 comments

Comments

@MethodenMann
Copy link

We'd like to use font-awesome icons for pagination compoment.
It works like this:

 const options = {
     nextPage: <i className="fa fa-chevron-right"></i>
  };

Unfortunately we get a prop type warning:

Warning: Failed prop type: Invalid prop options.nextPage of type object supplied to BootstrapTable, expected string.

Could you please make the proptypes less strict and allow jsx?

@AllenFang
Copy link
Owner

ok, it will be done in next version.

@MethodenMann
Copy link
Author

cool. thank you very much!

@AllenFang
Copy link
Owner

Fixed on newest version, thanks

@achepey
Copy link

achepey commented Sep 7, 2017

When trying to implement this on my own project, using the above syntax to inject an icon rather than a string, it seems to completely break the functionality.

@MethodenMann , were you able to get this working on the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants