Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New/unknown error message #1463

Closed
alexpiet opened this issue Mar 26, 2020 · 3 comments
Closed

New/unknown error message #1463

alexpiet opened this issue Mar 26, 2020 · 3 comments
Labels

Comments

@alexpiet
Copy link
Contributor

Describe the bug
When loading the trials data frame for a session, I get a new warning and error message.

To Reproduce
new_error

Expected behavior
Load without errors or warning

Actual Behavior

Environment (please complete the following information):

  • OS & version: Centos 7
  • Python version 3
  • AllenSDK version 1.6.0

@kschelonka @wbwakeman

@alexpiet alexpiet added the bug label Mar 26, 2020
@alexpiet
Copy link
Contributor Author

Email from Doug:

Alex, Kat has been working recently to improve the algorithm for display lag calculation. She has a PR on the SDK that I believe is close to ready to merge in. It’s here:
#1438
I’m not sure how much thought you’ve given to the display lag calculation, so forgive me if I’m stating the obvious, but there’s a square in the corner of the screen that is set to toggle between black/white every 60 visual frames. A photodiode is monitoring that square to detect those transitions. The old algorithm was only looking at a single direction of the edges (black-to-white or vice versa, but not both), so the number of measured transitions would often (I’m assuming half the time) end up being off-by-one. It looks like that’s what you encountered. I’m not quite sure why you’d just now be seeing this warning, though. I’m also not quite sure how the default value was changed, though this value looks more inline with values that Kat has been calculating with her improved algorithm.

@kschelonka
Copy link
Contributor

kschelonka commented Mar 27, 2020

Hi Alex,

To add to what Doug said -- before this coming update, we changed the default monitor delay calculation to be more in line with reality. You're seeing the warning text because we updated the code so that error messasges are no longer suppressed (previously they were). In the coming update, we are removing the default calculation, but cases like this example will be calculated properly.

@alexpiet
Copy link
Contributor Author

alexpiet commented Apr 1, 2020

Thanks @kschelonka !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants