Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for VBN metadata LIMS queries #2408

Open
1 task
danielsf opened this issue May 2, 2022 · 1 comment
Open
1 task

Add unit test for VBN metadata LIMS queries #2408

danielsf opened this issue May 2, 2022 · 1 comment

Comments

@danielsf
Copy link
Contributor

danielsf commented May 2, 2022

PR #2407 adds a lot of methods that do some simple (if verbose) lims queries. These queries can be found in

allensdk/brain_observatory/vbn_2022/metadata_writer/lims_queries.py

(assuming that organization persists beyond code review). Those queries are currently untested. It should be straightforward to write unit tests of these methods using sqlite3 to mock LIMS and MTRAIN during testing. It just requires personnel hours.

Tasks

  • Add unit tests for the VBN metadata LIMS API that can be run locally. Use sqlite3 (or something similar) to create a small test database with known structure that mocks LIMS and MTRAIN. Make sure that the LIMS query methods return the correct relationships between sessions, probes, and units.
@aamster
Copy link
Contributor

aamster commented May 3, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants