Try to merge VBN 2022 and VCN 2019 LIMS APIs

[danielsf]

#2407 created a lims_queries.py module to handle all of the LIMS database queries necessary to generate the metadata tables for the VBN 2022 release. There is an ecephys-related LIMS API here

https://github.com/AllenInstitute/AllenSDK/blob/master/allensdk/brain_observatory/ecephys/ecephys_project_api/ecephys_project_lims_api.py

however, it makes several strong assumptions about the where clauses that our stakeholders did not want to make when generating the VBN data release, specifically, the selection on WHERE ecephys_probes.valid_data. See

#2407 (comment)

for a brief discussion.

The purpose of this ticket is to try to modify the old LIMS API so that the lims_queries.py module created for the VBN 2022 metadata writer can rely on that code

Tasks

• Generate baseline metadata tables using python -m allensdk.brain_observatory.vbn_2022.metadata_writer. Save for validation.
• Add ability to old ecephys LIMS API to specify probe_ids_to_skip
• Add ability told ecephys LIMS API to turn off the hard selection on WHERE ecephys_probes.valid_data
• Modify VBN 2022 metadata writer lims_queries.py to use the old ecephys LIMS API to do its queries.

Validation

• Re-generate the metadata tables generated in the first step above. Make sure that their contents have not changed (or, if they have, make sure that there is a sound reason for that change).