Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweepbrowser does not support data from multiple devices in general #2151

Open
MichaelHuth opened this issue Jun 21, 2024 · 2 comments
Open

Comments

@MichaelHuth
Copy link
Collaborator

When given a sweepNo as argument with the simple FindValue approach the function returns only for the first hit.

Thus, we have code paths that are not aware of sweeps loaded from multiple experiment.

e.g. everything that uses also BSP_GetSweepDF

@MichaelHuth
Copy link
Collaborator Author

MichaelHuth commented Jun 24, 2024

Review all functions that use:
SB_GetSweepDataFolder, BSP_GetSweepDF

General changes:

Add a column a SweepMap with CRC of sweep number, experiment name, device name. Then function take these as argument, resolve indice through finding that CRC in SweepMap.

Change SB functions to use the mentioned three arguments for IDing a sweep.

@t-b t-b changed the title SB_GetSweepDataFolder is not aware of multiple loaded experiments Sweepbrowser does not support data from multiple devices in general Aug 13, 2024
@t-b
Copy link
Collaborator

t-b commented Aug 13, 2024

Before the GUI fixes we need to fix the code, partly done in #2109. The full fix would go over all relevant BSP/SB functions and revise them so that they are able to uniquely identify a sweep given sweep number/device/experiment.

GUI wise we need to fix three locations:

  • OVS panel

Options:

1.) We could either have three columns (sweeps, device, experiment) in the listbox. The user could then resort the listbox by clicking on the column label.
2.) We have somes kind of tree hierarchy where the sweeps are leaves and device/experiment are nodes. No expand/collapse support.
3.) Or we introduce two columns with background colors. The columns would color code the experiment and device. Each device type would have a fixed base color. Show the legend somewhere. Optional symbol on top of each color for better readability.

  • Selection popupmenu. Should have the device/experiment shown as well. Ellide experiment names to only show unique characters, at least ~10.

  • Dashboard

Same options as for OVS, but we don't have sweeps here but SCI's.

MichaelHuth added a commit that referenced this issue Oct 4, 2024
problem described in #2151

SF requires to retrieve the correct LNBs and sweepDFR for sweeps.
Through the analysisbrowser sweeps from multiple devices and/or
experiments can be loaded. This must be handled correctly or wrong
data is retrieved/analysed.

Thus, SF functions that retrieve sweep data are adapted to handle that
correctly. For selections a forth column was added to store the mapIndex
of the sweepMap that is unique for a sweepNo, experiment, device combination.

For graphs from SB the mapIndex is used to retrieve the correct LNB, SweepDF.

** THIS BUGFIX IS LIMITED TO SWEEP HANDLING IN SWEEPFORMULA **

Other parts of MIES may be still unaware of multiple experiment/devices in the SB.
MichaelHuth added a commit that referenced this issue Oct 5, 2024
problem described in #2151

SF requires to retrieve the correct LNBs and sweepDFR for sweeps.
Through the analysisbrowser sweeps from multiple devices and/or
experiments can be loaded. This must be handled correctly or wrong
data is retrieved/analysed.

Thus, SF functions that retrieve sweep data are adapted to handle that
correctly. For selections a forth column was added to store the mapIndex
of the sweepMap that is unique for a sweepNo, experiment, device combination.

For graphs from SB the mapIndex is used to retrieve the correct LNB, SweepDF.

** THIS BUGFIX IS LIMITED TO SWEEP HANDLING IN SWEEPFORMULA **

Other parts of MIES may be still unaware of multiple experiment/devices in the SB.
t-b pushed a commit that referenced this issue Oct 14, 2024
problem described in #2151

SF requires to retrieve the correct LNBs and sweepDFR for sweeps.
Through the analysisbrowser sweeps from multiple devices and/or
experiments can be loaded. This must be handled correctly or wrong
data is retrieved/analysed.

Thus, SF functions that retrieve sweep data are adapted to handle that
correctly. For selections a forth column was added to store the mapIndex
of the sweepMap that is unique for a sweepNo, experiment, device combination.

For graphs from SB the mapIndex is used to retrieve the correct LNB, SweepDF.

** THIS BUGFIX IS LIMITED TO SWEEP HANDLING IN SWEEPFORMULA **

Other parts of MIES may be still unaware of multiple experiment/devices in the SB.
t-b pushed a commit that referenced this issue Oct 15, 2024
problem described in #2151

SF requires to retrieve the correct LNBs and sweepDFR for sweeps.
Through the analysisbrowser sweeps from multiple devices and/or
experiments can be loaded. This must be handled correctly or wrong
data is retrieved/analysed.

Thus, SF functions that retrieve sweep data are adapted to handle that
correctly. For selections a forth column was added to store the mapIndex
of the sweepMap that is unique for a sweepNo, experiment, device combination.

For graphs from SB the mapIndex is used to retrieve the correct LNB, SweepDF.

** THIS BUGFIX IS LIMITED TO SWEEP HANDLING IN SWEEPFORMULA **

Other parts of MIES may be still unaware of multiple experiment/devices in the SB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants