-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sweepbrowser does not support data from multiple devices in general #2151
Comments
Review all functions that use: General changes: Add a column a SweepMap with CRC of sweep number, experiment name, device name. Then function take these as argument, resolve indice through finding that CRC in SweepMap. Change SB functions to use the mentioned three arguments for IDing a sweep. |
Before the GUI fixes we need to fix the code, partly done in #2109. The full fix would go over all relevant BSP/SB functions and revise them so that they are able to uniquely identify a sweep given sweep number/device/experiment. GUI wise we need to fix three locations:
Options: 1.) We could either have three columns (sweeps, device, experiment) in the listbox. The user could then resort the listbox by clicking on the column label.
Same options as for OVS, but we don't have sweeps here but SCI's. |
problem described in #2151 SF requires to retrieve the correct LNBs and sweepDFR for sweeps. Through the analysisbrowser sweeps from multiple devices and/or experiments can be loaded. This must be handled correctly or wrong data is retrieved/analysed. Thus, SF functions that retrieve sweep data are adapted to handle that correctly. For selections a forth column was added to store the mapIndex of the sweepMap that is unique for a sweepNo, experiment, device combination. For graphs from SB the mapIndex is used to retrieve the correct LNB, SweepDF. ** THIS BUGFIX IS LIMITED TO SWEEP HANDLING IN SWEEPFORMULA ** Other parts of MIES may be still unaware of multiple experiment/devices in the SB.
problem described in #2151 SF requires to retrieve the correct LNBs and sweepDFR for sweeps. Through the analysisbrowser sweeps from multiple devices and/or experiments can be loaded. This must be handled correctly or wrong data is retrieved/analysed. Thus, SF functions that retrieve sweep data are adapted to handle that correctly. For selections a forth column was added to store the mapIndex of the sweepMap that is unique for a sweepNo, experiment, device combination. For graphs from SB the mapIndex is used to retrieve the correct LNB, SweepDF. ** THIS BUGFIX IS LIMITED TO SWEEP HANDLING IN SWEEPFORMULA ** Other parts of MIES may be still unaware of multiple experiment/devices in the SB.
problem described in #2151 SF requires to retrieve the correct LNBs and sweepDFR for sweeps. Through the analysisbrowser sweeps from multiple devices and/or experiments can be loaded. This must be handled correctly or wrong data is retrieved/analysed. Thus, SF functions that retrieve sweep data are adapted to handle that correctly. For selections a forth column was added to store the mapIndex of the sweepMap that is unique for a sweepNo, experiment, device combination. For graphs from SB the mapIndex is used to retrieve the correct LNB, SweepDF. ** THIS BUGFIX IS LIMITED TO SWEEP HANDLING IN SWEEPFORMULA ** Other parts of MIES may be still unaware of multiple experiment/devices in the SB.
problem described in #2151 SF requires to retrieve the correct LNBs and sweepDFR for sweeps. Through the analysisbrowser sweeps from multiple devices and/or experiments can be loaded. This must be handled correctly or wrong data is retrieved/analysed. Thus, SF functions that retrieve sweep data are adapted to handle that correctly. For selections a forth column was added to store the mapIndex of the sweepMap that is unique for a sweepNo, experiment, device combination. For graphs from SB the mapIndex is used to retrieve the correct LNB, SweepDF. ** THIS BUGFIX IS LIMITED TO SWEEP HANDLING IN SWEEPFORMULA ** Other parts of MIES may be still unaware of multiple experiment/devices in the SB.
When given a sweepNo as argument with the simple FindValue approach the function returns only for the first hit.
Thus, we have code paths that are not aware of sweeps loaded from multiple experiment.
e.g. everything that uses also
BSP_GetSweepDF
The text was updated successfully, but these errors were encountered: