Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TTL export NWB tests #1820

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Enable TTL export NWB tests #1820

merged 4 commits into from
Jul 20, 2023

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Jul 14, 2023

No description provided.

@t-b
EP_FetchEpochs: Remove todo comment
9308323 
This was resolved in 137a5b2 (EP: Allow EP_FetchEpochs to retrieve epoch
information from TTL channels, 2023-06-21).
@t-b t-b self-assigned this Jul 14, 2023
@t-b t-b requested a review from timjarsky as a code owner July 14, 2023 21:24
@t-b
UTF_TestNWBExportV2.ipf/TestTimeSeries: Check TTL epochs
64d09ac 
Forgotten in e55bb43 (EP: Add function EP_CollectEpochInfoTTL that
creates epochs for TTL channels, 2023-06-22).
@t-b t-b force-pushed the bugfix/1820-enable-ttl-epochs-nwb-export-in-tests branch from 4dcb4db to 64d09ac Compare July 14, 2023 21:29
t-b added 2 commits July 14, 2023 23:31
@t-b
.github/workflows: Avoid using deprecated action
fe3b1de 
One of the latest pipeline runs shows

The following actions uses node12 which is deprecated and will be forced
to run on node16: actions/cache@v1. For more info:
https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

so let's move to v3.
@t-b
GetActiveChannelsTTL: Add introduction date of used LBN entries
7e39003
@t-b t-b assigned MichaelHuth and unassigned t-b Jul 16, 2023
@t-b
Copy link
Collaborator Author

t-b commented Jul 19, 2023

@MichaelHuth Please review.

@MichaelHuth MichaelHuth self-requested a review July 20, 2023 02:02
MichaelHuth
MichaelHuth approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@MichaelHuth MichaelHuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MichaelHuth MichaelHuth assigned t-b and unassigned MichaelHuth Jul 20, 2023
@t-b t-b merged commit ca807f0 into main Jul 20, 2023
@t-b t-b deleted the bugfix/1820-enable-ttl-epochs-nwb-export-in-tests branch July 20, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelHuth MichaelHuth MichaelHuth approved these changes

@timjarsky timjarsky Awaiting requested review from timjarsky timjarsky is a code owner

Assignees

@t-b t-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-b @MichaelHuth