Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #192

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Update README.md #192

merged 2 commits into from
Dec 7, 2023

Conversation

NullByte08
Copy link
Contributor

Reference: #10 (comment)

A workaround for this issue: #10

@MoralCode
Copy link
Collaborator

Thanks for the contribution! I notice that @Almoullim self-assigned the issue you mentioned so i hope it'll see a true root-cause fix soon. In the meantime thanks for your contribution! Do you think it would be better to explicitly mention that this is a workaround, like this:

Start the location service. This will also ask the user for permission if not asked previously by another package.

BackgroundLocation.startLocationService();

There is currently an open issue (#10) where, if the location service is started multiple times, the location callback will get called repeatedly. This can be worked around by calling BackgroundLocation.stopLocationService(); to stop any previous running services (such as from a previous run of the app) before starting a new one.

@NullByte08
Copy link
Contributor Author

Hi @MoralCode, thanks for your reply. I think it would be better to just directly tell the reader where the code needs to be added. It will be easier for the reader to understand. But we should explicitly mention the reason for adding the code as well, as suggested by you.

Start the location service. This will also ask the user for permission if not asked previously by another package.

BackgroundLocation.stopLocationService(); //To stop any previous running services (Read the note below)
BackgroundLocation.startLocationService();

Note: There is currently an open issue (#10) where, if the location service is started multiple times, the location callback will get called repeatedly. This can be worked around by calling BackgroundLocation.stopLocationService(); to stop any previous running services (such as from a previous run of the app) before starting a new one.

I think this workaround code line should be added everytime rather than the user first testing whether the bug is occurring and then him adding the line. It will lead to a better user experience of the plugin I think.
You can make changes to above as you need. Thanks.

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Oct 19, 2023
@MoralCode MoralCode removed the stale label Oct 19, 2023
Copy link

github-actions bot commented Dec 4, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Dec 4, 2023
@MoralCode MoralCode removed the stale label Dec 4, 2023
@MoralCode MoralCode merged commit 2a90232 into Almoullim:master Dec 7, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants