[BUG] no e-mail notification on chat messages

[Veraellyunjie]

In profile settings:

Receive e-mails on likes and matches
Receive e-mails on chats

both have been ticked.

I got an e-mail on a match
but I also got chat messages but no e-mail about them

[Veraellyunjie]

Update:
I am now emailed You have a new message!.
But:

There is wrong placement of my name and the name of the person I chat with:

Hi %THEY%,

%ME% just sent you a message! Time to send them a message back.

I would expect it to be:

Hi %ME%,

%THEY% just sent you a message! Time to send them a message back.

I get as many emails as there were chat messages, even though they comprise a single communication session, so I would expect a single email. Perhaps introduce a timeout, say, 1 hour?

[Nonononoki]

1. Issue with swapped names should now be fixed: d871d0c
2. Not sure how to handle the email per message problem. A timeout of 1 hour is pretty long. My suggesion:

• Only send an email when the last message is NOT from the sender. In this case you only get one email if the sender sends 100 messages after another.
• Only send an email when the user hasn't been online recently. If the user has been online for X seconds don't send an email.

[lucifercr07]

@Nonononoki would like to work on this, let me know if there's any other issue of higher priority you would like me to pick up.

[Nonononoki]

@lucifercr07 Sure, thanks! :)

Requirements:

• Do NOT send a chat email if the previous message is less than an hour ago.
• Threshold is configurable in application.properties (app.mail.chat.min-threshold).

Hints:

• Do it in MessageService
• Don't forget unit tests

[Nonononoki]

@lucifercr07 Any progress on this topic? Otherwise I will start working on this.

[andresousadotpt]

@Nonononoki if @lucifercr07 don't want I would like to work on it :) (My first open-source contribution :D)

[lucifercr07]

@andresousadotpt please pick it up, have been busy with other projects wouldn't be able to work on this currently. Thanks.

[andresousadotpt]

I will be getting on this by friday :)

[Nonononoki]

@andresousadotpt I already did some work with this commit 7fc3661

[andresousadotpt]

Oh @Nonononoki then do you need help in other issues? You can keep working on this haha :)

[Nonononoki]

@andresousadotpt Added a new feature ticket #413, feel free to work on it :)

Closing this issue now.