Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload to GCS error #517

Closed
mmolinac opened this issue Sep 20, 2022 · 2 comments
Closed

Upload to GCS error #517

mmolinac opened this issue Sep 20, 2022 · 2 comments
Assignees
Milestone

Comments

@mmolinac
Copy link

Hi,
It's only recently we're getting errors when uploading files to GCS, like this:

2022/09/17 01:11:21.636318 error one of upload go-routine return error: one of uploadTableData go-routine return error: can't check uploaded file: key not found

or this other one:

2022/09/20 04:10:51.581880  warn can't close writer: googleapi: Error 503: We encountered an internal error. Please try again., backendError
2022/09/20 04:10:51.644658 error can't acquire semaphore during Upload data parts: context canceled
2022/09/20 04:10:51.798495  warn can't close writer: googleapi: Error 503: We encountered an internal error. Please try again., backendError
2022/09/20 04:10:52.714160  warn can't close writer: googleapi: Error 503: We encountered an internal error. Please try again., backendError
2022/09/20 04:10:53.604868  warn can't close writer: googleapi: Error 503: We encountered an internal error. Please try again., backendError
2022/09/20 04:10:53.667549 error can't acquire semaphore during Upload data parts: context canceled
2022/09/20 04:10:54.037670  warn can't close writer: googleapi: Error 503: We encountered an internal error. Please try again., backendError
2022/09/20 04:10:54.114429 error can't acquire semaphore during Upload data parts: context canceled
2022/09/20 04:10:54.511411  warn can't close writer: googleapi: got HTTP response code 503 with body: Service Unavailable

I've seen that there's a fixed retry count for S3, as mentioned by @AlexAkulov in #36 (comment) .

I can't see if there's something similar in https://github.com/AlexAkulov/clickhouse-backup/blob/master/pkg/storage/gcs.go .

Is the app trying several times already or does it stop after first error?

Regards,
Manuel

@Slach
Copy link
Collaborator

Slach commented Sep 20, 2022

it should stop after first error now
we try to add storage independent retry mechanism in 2.1.0

@Slach Slach self-assigned this Sep 27, 2022
@Slach Slach added this to the 2.1.0 milestone Sep 27, 2022
@Slach
Copy link
Collaborator

Slach commented Oct 13, 2022

implements in altinity/clickhouse-backup:master duplicated with #397

@Slach Slach closed this as completed Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants