-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow backup+restore mutation with "in progress" status, disallow backup tables and parts have inconsistent structure #529
Comments
Yet another idea:
|
need create properly test case to test behavior to avoid race-condition state, I tried something like CREATE TABLE t1 (v UInt64, m UInt64) ENGINE=MergeTree() PARTITION BY v ORDER BY v;
INSERT INTO t1 SELECT number, number FROM numbers(99);
SYSTEM STOP MERGES;
ALTER TABLE t1 MODIFY COLUMN m String;
SELECT type, active, count() FROM system.parts_columns WHERE table='t1' AND column='m' GROUP BY type, active FORMAT Vertical; but ALTER TABLE is stuck when MERGES stop ... Need ideas how to make possible ALTER TABLE ... in progress state and make ALTER TABLE ... FREEZE .. |
ATTACH PART works perfectly , ATTACH TABLE doesn't need but need to add |
to disallow backup inconsistent types in data parts need execute SELECT database, table, column, uniqExact(type) AS column_types
FROM system.parts_columns
WHERE active
GROUP BY database, table, column
HAVING column_types>1 and add separate config option clickhouse->check_parts_columns and CLI parameter |
/var/lib/clickhouse/backup/backup_name/shadow/db/table/disk/part_name
->/var/lib/clickhouse/(data/db/table|store/uuid)/detached/part_name
The text was updated successfully, but these errors were encountered: