Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement config panel for pages #12288

Closed
Tracked by #12094
nkylstad opened this issue Feb 12, 2024 · 0 comments · Fixed by #12442
Closed
Tracked by #12094

Implement config panel for pages #12288

nkylstad opened this issue Feb 12, 2024 · 0 comments · Fixed by #12442

Comments

@nkylstad
Copy link
Member

nkylstad commented Feb 12, 2024

Description

Current view when a page is "selected" (but no component is selected) is:
Screenshot 2024-02-12 at 12 01 59

We should update this to allow editing of the following on page-level:

  • page id (this is currently handled in the context-menu for the page)
  • text resource for the page name
    • this should be represented as the page id as key in the text resource file. When that key is present, the page name from the text resource is automatically used in the navigationBar component.
  • expressions on hidden prop - this will be covered by Implement expressions editor for hidden property on layout #12185 and is not part of this issue

Suggested design:

Image

The implementation should follow the same design/setup as we are working on for components:

  • ID (page name) always visible at the top
  • Texts - for text resource bindings
  • Dynamics - for expressions.
@standeren standeren self-assigned this Mar 4, 2024
@standeren standeren moved this to 👷 In Progress in Team Studio Mar 4, 2024
@standeren standeren linked a pull request Mar 5, 2024 that will close this issue
4 tasks
@standeren standeren moved this from 👷 In Progress to 🔎 Review in Team Studio Mar 12, 2024
@standeren standeren removed their assignment Mar 12, 2024
@TomasEng TomasEng self-assigned this Mar 12, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Mar 15, 2024
@JamalAlabdullah JamalAlabdullah self-assigned this Mar 18, 2024
@JamalAlabdullah JamalAlabdullah moved this from 🧪 Test to ✅ Done in Team Studio Mar 18, 2024
@JamalAlabdullah JamalAlabdullah removed their assignment Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants