Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated model-metadata file when we generate model #12529

Closed
nkylstad opened this issue Mar 18, 2024 · 1 comment · Fixed by #12655
Closed

Remove outdated model-metadata file when we generate model #12529

nkylstad opened this issue Mar 18, 2024 · 1 comment · Fixed by #12655
Labels
kind/user-story Used for issues that describes functionality for our users. status/ready-for-dev Status: Used for issues that are ready for development. Has been through grooming.

Comments

@nkylstad
Copy link
Member

Description

We no longer persist the model metadata <model>.metadata.json in the app repo, as this is a data structure that we generate as needed.
Apps with existing data models will end up with outdated model metadata files, as an updated file is not generated.
We should therefore remove this file where it exists when a user updates their model and then generates all model files.

Additional Information

No response

Tasks

No response

Acceptance Criterias

No response

@nkylstad nkylstad added kind/user-story Used for issues that describes functionality for our users. status/draft Status: When you create an issue before you have enough info to properly describe the issue. labels Mar 18, 2024
@nkylstad nkylstad added the status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design. label Mar 18, 2024
@nkylstad nkylstad added status/ready-for-dev Status: Used for issues that are ready for development. Has been through grooming. and removed status/draft Status: When you create an issue before you have enough info to properly describe the issue. status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design. labels Apr 3, 2024
@nkylstad nkylstad moved this to 📈 Todo in Team Studio Apr 8, 2024
@standeren standeren moved this from 📈 Todo to 👷 In Progress in Team Studio Apr 9, 2024
@standeren standeren self-assigned this Apr 9, 2024
@standeren standeren linked a pull request Apr 10, 2024 that will close this issue
3 tasks
@standeren standeren moved this from 👷 In Progress to 🔎 Review in Team Studio Apr 11, 2024
@standeren standeren removed their assignment Apr 11, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Apr 15, 2024
@nkylstad
Copy link
Member Author

Tested OK in dev.

Tested with existing app that had the model metadata file:

  • ensured that local user was up-to-date with central repo
  • added a new field to data model and generated model files
  • pushed changes to central repo
    Result: model metadata file was removed.

Tested with existing app that does not have the model metadata file:

  • ensured that local user was up-to-date with central repo
  • added a new field to data model and generated model files
  • pushed changes to central repo
    Result: model generation works as expected with no errors. Model metadata file is not generated, and the fact that it does not exist does not cause any errors with model generation.

@nkylstad nkylstad moved this from 🧪 Test to ✅ Done in Team Studio Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story Used for issues that describes functionality for our users. status/ready-for-dev Status: Used for issues that are ready for development. Has been through grooming.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants