Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically delete all Summary 2.0 components that has a reference to deleted element (component, page or layout-set). #13525

Closed
3 tasks
framitdavid opened this issue Sep 11, 2024 · 4 comments
Labels

Comments

@framitdavid
Copy link
Collaborator

framitdavid commented Sep 11, 2024

User Story

As a user, I can delete a component that is referenced within a Summary 2.0 component. When I delete the referenced component in Studio, Studio should automatically delete all Summary 2.0 components that reference the deleted component. I expect the same behaviour when deleting pages and layout sets that are referenced in the Summary 2.0 component.

As a user, I should receive a confirmation message before the deletion occurs, informing me of the deletion and its consequences if I as user proceed/confirm the deletion.

Purpose of the User Story

The studio/designer should serve as a helpful tool for "tjenesteutvikler" to develop "tjenester" without the need to manually track and synchronize references between components and files, which is an implementation detail.

Technical Requirements

The backend should handle updating all necessary files and notify the frontend via web sockets. This will allow the frontend to invalidate queries as needed.

Note: we must do NOT make multiple mutation requests from the frontend, the backend should handle it as described above.

Acceptance criteria

  • I as a user can delete a component and its referenced Summary 2.0 component is deleted.
  • I as a user can delete a page and its referenced Summary 2.0 component is deleted.
  • I as a user can delete a layout-set and its referenced Summary 2.0 component is deleted.
@framitdavid framitdavid changed the title Sync summary-2 configuration of component is deleted tudio should automatically delete all Summary 2.0 components that referenced element is deleted. (component, page or layout-set) Sep 11, 2024
@framitdavid framitdavid added the status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design. label Sep 11, 2024
@framitdavid framitdavid changed the title tudio should automatically delete all Summary 2.0 components that referenced element is deleted. (component, page or layout-set) Studio should automatically delete all Summary 2.0 components that referenced element is deleted. (component, page or layout-set) Sep 11, 2024
@framitdavid framitdavid changed the title Studio should automatically delete all Summary 2.0 components that referenced element is deleted. (component, page or layout-set) Automatically delete all Summary 2.0 components that has a reference to deleted element (component, page or layout-set). Sep 11, 2024
@framitdavid framitdavid added ux UX help needed ux/accessebility Related to WCAG, accessebilty and UU UX research labels Sep 24, 2024
@Annikenkbrathen
Copy link

Some questions we might want to consider:
How important is it to show the user exactly what will be removed? Is it sufficient with a general message that the component will disappear from all places where it is used/referenced, including the summary?

Or do we need to say anything at all? Isn’t it obvious to the user that it will also disappear from the summary? Do we need to show it at all?

Maybe you have any thoughts at this @Ildest

@Ildest
Copy link
Contributor

Ildest commented Sep 30, 2024

For now, I think that as long as the warning before you delete (general message) is clear on what´s going to happen, we don´t need to say/show anything else.

@wrt95 wrt95 added team/studio-domain2 frontend backend and removed status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design. labels Oct 30, 2024
@nkylstad
Copy link
Member

nkylstad commented Nov 4, 2024

Split in multiple tasks.

If Summary2 is connected to:

  • A component: Delete summary2 component if component is deleted.
  • A page: Delete summary 2 component if page is deleted.
  • A layoutset: Delete summary2 component if layoutset is deleted

If Summary2 has component overrides:

  • Delete the override in summary2 component if component is deleted, but DO NOT delete the summary2 component itself (unless it is also connected to the same component directly)

@lassopicasso lassopicasso removed their assignment Jan 20, 2025
@lassopicasso
Copy link
Contributor

Done 🙂 #14126

@github-project-automation github-project-automation bot moved this from 🧪 Test to Documentation in Team Studio Jan 20, 2025
@lassopicasso lassopicasso moved this from Documentation to ✅ Done in Team Studio Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

8 participants