Repositories: Username varies between PRs made from local development and Studio

[mijohansen]

Description of the bug

There seem to be different users that is connected to the environment in dev and prod.

Steps To Reproduce

1. Create an app.
2. Check it out locally, make a commit to master.
3. Open the app in the approprate altinn studio enviroment
4. Make a change and commit the change to master.
5. Now go to gitea and observe that the commits is made by different users

Additional Information

No response

[ivarne]

A commit is attributed to a user using the Name and email fields in git. Commits are created in 3 environments

• Locally on the users computer (user can set whatever they want. Will probably be linked in gitea based on email)
• Commits an Merge commits in Altinn Studio. (set by altinn studio (seems to be [username] and <@jugglingnutcase>))
• Merge commits and edits directly in Gitea (seems to be set to [username] and [username]@noreply.altinn.no)

Seemes like it would be good to have Altinn studio set something more sensible. The local environment must be fixed by better docs.

[mijohansen]

Thanx, @ivarne. This is a minor, but annoying bug.

[mijohansen]

This mysterious @jugglingnutcase seem to come from the example code: https://github.com/libgit2/libgit2sharp/wiki/Git-commit

Doesn't seem to have any real meaning other than actually "this code is example code, please change". Guess I can try to fix it.

[ivarne]

Seems like a pretty easy fix. https://github.com/Altinn/altinn-studio/compare/master...ivarne:altinn-studio:noJugglinutcase?expand=1

[mijohansen]

Nice, @ivarne ... bring it on! 💯